WrapFieldElement: differentiate between zero and undefined #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@lnobrega-canarie thank you so much for spotting this and for the proposed fix. I have added a suggestion to make it slightly more general so other falsy values don't get nixed aswell. Could you check if this works for you to? |
Author
lnobrega-canarie
left a comment
lnobrega-canarie
left a comment
There was a problem hiding this comment.
Typing a number then backspacing until the field is empty causes an error.
DutchBen
approved these changes
Oct 30, 2025
Georgi2704
reviewed
Nov 5, 2025
| onChange={onChangeHandle} | ||
| onBlur={onBlur} | ||
| value={value || ''} | ||
| value={!_.isUndefined(value) ? value : ''} |
Contributor
There was a problem hiding this comment.
Do you want null to pass through as well ?
If not then I would suggest just using value ?? ''
Collaborator
There was a problem hiding this comment.
Yes Null could be a valid option I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #191