Add new support area #24937
Add new support area #24937
Conversation
Generated by 🚫 Danger |
jkmassel
force-pushed
the
add/new-support
branch
3 times, most recently
from
72009e5 to
6343fa1
Compare
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29587 | |
| Version | PR #24937 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 44eb13c | |
| Installation URL | 5u22ktac8o620 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29587 | |
| Version | PR #24937 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 44eb13c | |
| Installation URL | 6pkmkjri1oeu0 |
jkmassel
force-pushed
the
add/new-support
branch
from
f13958e to
6d824f5
Compare
jkmassel
force-pushed
the
add/new-support
branch
from
ef5f074 to
e6ef356
Compare
| ) | ||
| } | ||
| } | ||
| .navigationTitle("Activity Logs") |
There was a problem hiding this comment.
Should this be "Application Logs", which is what the list row says?
There was a problem hiding this comment.
Yeah, good call – done in 10bc235
| .navigationTitle("Diagnostics") | ||
| .background(.background) | ||
| .onAppear { | ||
| dataProvider.userDid(.viewDiagnostics) |
There was a problem hiding this comment.
Tapping "System Status Report" crashes here. dataProvider env not set?
There was a problem hiding this comment.
Ah yep – that's what I get for changing this last-second. Fixed in 314b74d
| import SwiftUI | ||
| import PhotosUI | ||
|
|
||
| public struct SupportForm: View { |
There was a problem hiding this comment.
This view does not have a cancel button. Even though we can swipe down to dismiss it, I think the app usually still shows an X or "Close" button on similar screens.
There was a problem hiding this comment.
I'll come back to this one – it needs to push the user over to the conversation, which will require some server-side work.
| } else { | ||
| let data = Data(email.trimmingCharacters(in: .whitespacesAndNewlines).lowercased().utf8) | ||
| let hash = SHA256.hash(data: data).compactMap { String(format: "%02x", $0) }.joined() | ||
| self.avatarUrl = URL(string: "https://gravatar.com/avatar/\(hash)")! |
There was a problem hiding this comment.
Nitpick: This avatar is pretty low resolution. https://gravatar.com/avatar/f4c1e6c0cacd4334b01566831e489c92199ef102f2ed5e1267c77a66b827f330
| label: { | ||
| Image(systemName: "square.and.pencil") | ||
| } | ||
| .disabled(!currentUser.permissions.contains(.createChatConversation)) |
There was a problem hiding this comment.
This button is disabled for my test accounts. Not sure why...
There was a problem hiding this comment.
I'd guess it's because they don't have a paid WP.com plan?
|
|
Merging this so I can sync up #24925. We can change anything we need to later. |
4 participants
Description
Adds the updated support area powered by
wprs.Adds:
This PR also uses a disk-based cache for support data so that content can be shown right away while the latest data is fetched from the server. This behaviour is encoded in the
CachedAndFetchedResulttype, which will later support thesqlitecaching layer.Testing instructions
Run on-device and try it out. There are a few dead ends (like creating a support ticket doesn't take you to the conversation view) and missing features (attaching images and application logs is waiting for @crazytonyli's work on the Rust layer), but this PR is pretty big already and fixing the missing bits won't dramatically change the overall approach.