Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Dec 1, 2025

Description

Ref CMM-1005. Improve the deep link experience by navigating to an individual post detail view rather than the top-level Reader view.

Testing instructions

See Automattic/wp-calypso#107407.

reader-deep-links.mp4

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 1, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Improve the deep link experience by navigating to an individual post
detail view rather than the top-level Reader view.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22380-08f5081
Commit08f5081
Direct Downloadjetpack-prototype-build-pr22380-08f5081.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22380-08f5081
Commit08f5081
Direct Downloadwordpress-prototype-build-pr22380-08f5081.apk
Note: Google Login is not supported on these builds.

long blogId,
long postId,
boolean isFeed,
Uri uri

Check notice

Code scanning / Android Lint

Nullable/NonNull annotation missing on method parameter Note

Missing null annotation
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.03%. Comparing base (2be71e4) to head (08f5081).

Files with missing lines Patch % Lines
...android/ui/deeplinks/handlers/ReaderLinkHandler.kt 91.30% 0 Missing and 2 partials ⚠️
...ordpress/android/ui/deeplinks/DeepLinkNavigator.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22380      +/-   ##
==========================================
+ Coverage   39.02%   39.03%   +0.01%     
==========================================
  Files        2203     2203              
  Lines      106351   106376      +25     
  Branches    15061    15067       +6     
==========================================
+ Hits        41501    41523      +22     
- Misses      61359    61360       +1     
- Partials     3491     3493       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun dcalhoun force-pushed the feat/deep-link-opens-reader-post-detail-view branch from a10b434 to 08f5081 Compare December 1, 2025 21:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand of DEEP_LINK_HOST_READ and DEEP_LINK_HOST_VIEWPOST, these changes are sound and do not introduce regressions. However, I am less familiar with this code and welcome additional review and testing.

@dcalhoun dcalhoun marked this pull request as ready for review December 1, 2025 21:30
@dcalhoun dcalhoun requested a review from adalpari December 1, 2025 21:30
@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 1, 2025

@adalpari I just discovered #22374. This PR undoubtedly conflicts with efforts there. Let me know if you think these changes are worth keeping in some form or if they should be discarded.

@adalpari
Copy link
Contributor

adalpari commented Dec 2, 2025

@adalpari I just discovered #22374. This PR undoubtedly conflicts with efforts there. Let me know if you think these changes are worth keeping in some form or if they should be discarded.

Definitely, there seems to be some collisions. Also, the other PR is targeting the release branch and not trunk. So, merging both could be tricky.
I would say to wait on this one and see what extra changes are necessary after merging the general deelinks PR to support your changes in Automattic/wp-calypso#107407

@adalpari
Copy link
Contributor

adalpari commented Dec 2, 2025

I've included the necessary changes in 3817aa1, so I think it's safe to close this PR

Thank you for taking care of it! :)

@dcalhoun dcalhoun closed this Dec 2, 2025
@dcalhoun dcalhoun deleted the feat/deep-link-opens-reader-post-detail-view branch December 2, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants