-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Navigate to Reader post detail view deep links #22380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
Improve the deep link experience by navigating to an individual post detail view rather than the top-level Reader view.
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22380-08f5081 | |
| Commit | 08f5081 | |
| Direct Download | jetpack-prototype-build-pr22380-08f5081.apk |
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22380-08f5081 | |
| Commit | 08f5081 | |
| Direct Download | wordpress-prototype-build-pr22380-08f5081.apk |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22380 +/- ##
==========================================
+ Coverage 39.02% 39.03% +0.01%
==========================================
Files 2203 2203
Lines 106351 106376 +25
Branches 15061 15067 +6
==========================================
+ Hits 41501 41523 +22
- Misses 61359 61360 +1
- Partials 3491 3493 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a10b434 to
08f5081
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand of DEEP_LINK_HOST_READ and DEEP_LINK_HOST_VIEWPOST, these changes are sound and do not introduce regressions. However, I am less familiar with this code and welcome additional review and testing.
Definitely, there seems to be some collisions. Also, the other PR is targeting the release branch and not trunk. So, merging both could be tricky. |
|
I've included the necessary changes in 3817aa1, so I think it's safe to close this PR Thank you for taking care of it! :) |





Description
Ref CMM-1005. Improve the deep link experience by navigating to an individual post detail view rather than the top-level Reader view.
Testing instructions
See Automattic/wp-calypso#107407.
reader-deep-links.mp4