download_changesets_uid.sh #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2023 22:56
Apply similar changes as just checked in to download_changesets.sh Also moved start date in download_changesets.sh back to 2013.
Collaborator
|
try |
it was only ever an extreme outlier and it has now been removed from the data.
AntonKhorev
reviewed
Aug 20, 2023
Undo.pm
Outdated
| my $override_version; | ||
| my $override = 0; | ||
| my $force = 0; # if this is set to 1, any object touched by the undo userwill be reverted even if there are later modifications by others | ||
| my $force = 1; # if this is set to 1, any object touched by the undo userwill be reverted even if there are later modifications by others |
Collaborator
There was a problem hiding this comment.
Wasn't this pull request about shell scripts? They don't call perl scripts.
Collaborator
Author
There was a problem hiding this comment.
It was - that change to Undo.pm shouldn't have been in here.
even though very often it will need to be set to force through changes.
Collaborator
Author
|
No need for this any more - "user_changesets.pl" does that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply similar changes as just checked in to download_changesets.sh
Also moved start date in download_changesets.sh back to 2013 (I changed that for testing and forgot to change it back).
As before, this is just a "get it working 99% of the time again" fix - likely the way forward is #31 .