Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 2, 2025

WOOMOB-1647

Description

This PR migrates the payment flow from the deprecated two-step API (collectPaymentMethod() + confirmPaymentIntent()) to the new single-call processPaymentIntent() API in Stripe Terminal SDK 5.0.

Changes:

  • Add ProcessPaymentIntentAction for the new single-call payment API
  • Update PaymentManager to use processPaymentIntent instead of separate collect and confirm steps
  • Remove CollectingPayment status since collection and processing are now combined
  • Consolidate CollectingPayment UI states into ProcessingPayment
  • Remove deprecated CollectPaymentAction and ProcessPaymentAction classes

This is PR 4 of the Stripe SDK 5.0.0 migration series and depends on PR 3 (refund migration).

Test Steps

  1. Connect a card reader (external Bluetooth or Tap to Pay)
  2. Create an order and initiate card payment
  3. Verify payment flow shows "Processing Payment" state (no separate "Collecting" state)
  4. Complete the payment and verify success
  5. Test payment cancellation during processing
  6. Test payment failure scenarios
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1dae702
Direct Downloadwoocommerce-wear-prototype-build-pr15050-1dae702.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1dae702
Direct Downloadwoocommerce-prototype-build-pr15050-1dae702.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2025

🤖 Test Failure Analysis

Your tests failed. Claude has analyzed the failures - check the annotation for details.

@kidinov kidinov added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. dependencies Pull requests that update a dependency file labels Dec 3, 2025
@kidinov kidinov added this to the 23.9 milestone Dec 3, 2025
@kidinov kidinov requested a review from malinajirka December 3, 2025 06:34
@kidinov kidinov marked this pull request as ready for review December 3, 2025 06:34
@malinajirka malinajirka self-assigned this Dec 3, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kidinov ! The changes look good to me. I tested various errors as well as successful payments. I have not tested TTP since it require a release build - I can do a more thorough test on the final PR before we merge all these changes.

Base automatically changed from woomob-1647-pr3-migrate-refunds to woomob-1647-update-stripe-sdk-to-500 December 4, 2025 07:14
@kidinov kidinov merged commit ed57320 into woomob-1647-update-stripe-sdk-to-500 Dec 4, 2025
21 of 24 checks passed
@kidinov kidinov deleted the woomob-1647-pr4-migrate-payments branch December 4, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file feature: mobile payments Related to mobile payments / card present payments / Woo Payments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants