Migrate WCShippingLabelCreationEligibility to Room
#15008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert model to data class with Room annotations - Use composite primary key [localSiteId, remoteOrderId] - Replace synthetic primary key with LocalId/RemoteId types - Add ShippingLabelCreationEligibilityDao with upsert and query methods - Add comprehensive DAO unit tests covering all operations - Table name: ShippingLabelCreationEligibilityEntity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Update WCShippingLabelStore to use ShippingLabelCreationEligibilityDao - Make store constructor internal to allow internal DAO injection - Use runBlocking for DAO calls outside coroutines - Remove rowsAffected handling - Delete WCShippingLabelSqlUtils 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Register WCShippingLabelCreationEligibility entity in WCAndroidDatabase - Add ShippingLabelCreationEligibilityDao to database - Increment database version from 74 to 75 - Add AutoMigration(from = 74, to = 75) - Add WellSql migration 234 to drop legacy table 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Remove ADDON_WOOCOMMERCE parameter from test configurations - Update WCDataStoreTest, WCProductStoreTest, WCShippingLabelStoreTest - Update WooCommerceStoreTest, WCLeaderboardsStoreTest, WCProductLeaderboardsMapperTest - Remove unused WellSqlConfig imports 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Without this provider, Hilt cannot inject the DAO into WCShippingLabelStore, causing build failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Base automatically changed from
migrate_order_shipment_tracking_model
to
trunk
November 27, 2025 17:36
wzieba
changed the title
WCShippingLabelCreationEligibility to Room
wzieba
added
the
type: technical debt
…e to remove addon configuration to fix WellException: Generated classes for addon not found.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15008 +/- ##
=========================================
Coverage 38.61% 38.61%
Complexity 10312 10312
=========================================
Files 2163 2163
Lines 122674 122654 -20
Branches 16934 16930 -4
=========================================
Hits 47366 47366
+ Misses 70503 70483 -20
Partials 4805 4805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wzieba
force-pushed
the
migrate_shipping_label_creation_eligibility
branch
from
73d75ee to
c19180f
Compare
wzieba
force-pushed
the
migrate_shipping_label_creation_eligibility
branch
from
c19180f to
73d75ee
Compare
…remote` prefixes This is redundant, as we use types for this
irfano
approved these changes
Dec 4, 2025
Contributor
irfano
left a comment
irfano
left a comment
There was a problem hiding this comment.
LGTM and works as expected. I left minor feedback, but I’m approving. 🚢
| } | ||
|
|
||
| @Test | ||
| fun `when eligibility is not eligible with reason, then reason is persisted`() = runTest { |
Contributor
There was a problem hiding this comment.
This test is actually doing the exact same thing as when eligibility is upserted, then it can be retrieved. Its only benefit is that it states its purpose more explicitly. Feel free to ignore, but I prefer keeping the test suite less crowded.
Contributor
Author
There was a problem hiding this comment.
Thank you, I totally agree! I missed this when reviewing AI, fixed in: 29beb60
It's actually duplicate of existing test. See: https://github.com/woocommerce/woocommerce-android/pull/15008\#discussion_r2589577060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
WCShippingLabelCreationEligibilityfrom WellSql to Room.The migration, like always, focuses on actually migrating database entities and not fixing threading issues. All database calls on main thread are now more visible though, because of the runBlocking usage.
Test Steps
Testing this PR requires a site with the old shipping labels flow. See this internal Slack thread for details and website, which has this flow enabled right now: p1764335185877589/1764334560.167769-slack-C03L1NF1EA3
ShippingLabelCreationEligibilityEntitytable.Images/gif
Before (trunk)
After
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.