Update Go to 1.26.1, also update email address and PGP key in SECURITY.md#102
Update Go to 1.26.1, also update email address and PGP key in SECURITY.md#102wollomatic merged 5 commits intomainfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request updates the Docker build base image (Go 1.26.0 → 1.26.1), bumps a documented image tag (1.11.3 → 1.11.4) and adds HEAD-request examples in README, and revises the security policy (hash algorithm, contact email, PGP key details and download link). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
SECURITY.md (1)
27-34:⚠️ Potential issue | 🟠 MajorUpdate PGP key information: embedded key has expired and does not match the download link.
The embedded PGP public key block (lines 29–34) has expired as of 31 December 2025. Additionally, the key ID from the download link (
9123F130) does not match the fingerprint of the embedded key (D57424AC7C262F4B44F45B575586B7A4D15E6CA7), creating ambiguity for users attempting to encrypt vulnerability reports.Replace the embedded key block with the current, valid key from the download link, or clarify which key should be used.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@SECURITY.md` around lines 27 - 34, Replace the expired/incorrect embedded PGP public key block in SECURITY.md (the pasted PGP PUBLIC KEY BLOCK and the fingerprint D57424AC7C262F4B44F45B575586B7A4D15E6CA7) with the current valid key that matches the download link key ID 9123F130; alternatively remove the embedded block and add a clear statement directing users to download and verify the correct public key from the provided URL and include the correct fingerprint and key ID (9123F130) for verification. Ensure the file now either contains the up-to-date key text that matches the download link or a clarified instruction referencing the download link and the correct fingerprint/key ID for verification.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@SECURITY.md`:
- Line 27: Replace the insecure HTTP PGP key download URL in SECURITY.md (the
line containing "http://wollomatic.dev/gpg/9123F130.gpg.asc") with its HTTPS
equivalent and verify the HTTPS endpoint is valid and serves the same key;
update the markdown link to "https://wollomatic.dev/gpg/9123F130.gpg.asc" (or an
alternative trusted HTTPS key server) so the PGP key download is protected
against MITM tampering.
---
Outside diff comments:
In `@SECURITY.md`:
- Around line 27-34: Replace the expired/incorrect embedded PGP public key block
in SECURITY.md (the pasted PGP PUBLIC KEY BLOCK and the fingerprint
D57424AC7C262F4B44F45B575586B7A4D15E6CA7) with the current valid key that
matches the download link key ID 9123F130; alternatively remove the embedded
block and add a clear statement directing users to download and verify the
correct public key from the provided URL and include the correct fingerprint and
key ID (9123F130) for verification. Ensure the file now either contains the
up-to-date key text that matches the download link or a clarified instruction
referencing the download link and the correct fingerprint/key ID for
verification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aa93a333-20a5-4f92-a32e-6934a2aded96
📒 Files selected for processing (3)
DockerfileREADME.mdSECURITY.md
Summary by CodeRabbit
Release Notes
Documentation
Chores