waveshare_esp32s3_32MB_hub75 - audio support#5692
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ChangesWaveshare ESP32-S3 HUB75 Environment Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platformio.ini`:
- Around line 798-799: The build_unflags variable reference on line 798 uses
incorrect PlatformIO interpolation syntax with the env: prefix. In PlatformIO,
the env: prefix is reserved for system environment variables, not for
cross-environment section references. Change the interpolation syntax from
${env:esp32S3_wroom2_32MB.build_unflags} to ${esp32S3_wroom2_32MB.build_unflags}
by removing the env: prefix to properly reference the parent environment's
build_unflags variable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cdeb94a6-1a23-4480-b42d-facd8a80a8c2
📒 Files selected for processing (2)
.github/platformio_release.ini.templateplatformio.ini
| ; -D SD_PRINT_HOME_DIR | ||
| -D BTNPIN=0 | ||
| -D I2CSDAPIN=47 -D I2CSCLPIN=48 | ||
| -D SR_DMTYPE=9 -D I2S_SDPIN=39 -D I2S_CKPIN=43 -D I2S_WSPIN=38 -D MCLK_PIN=12 ; Waveshare ES8311 Codec pins |
There was a problem hiding this comment.
dmtype=9 (ES8311) is only supported in the WLED-MM (out-of-tree) variant of audioreactive. maybe add a comment to clarify this.
There was a problem hiding this comment.
which is exactly what this env is building against ;)
…17754 ;; SR_DMTYPE 254 fix
Fresh PR with just the waveshare changes, unlike #5660
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Chores