Skip to content

waveshare_esp32s3_32MB_hub75 - audio support#5692

Open
netmindz wants to merge 4 commits into
wled:mainfrom
netmindz:waveshare_esp32s3_32MB_hub75
Open

waveshare_esp32s3_32MB_hub75 - audio support#5692
netmindz wants to merge 4 commits into
wled:mainfrom
netmindz:waveshare_esp32s3_32MB_hub75

Conversation

@netmindz

@netmindz netmindz commented Jun 20, 2026

Copy link
Copy Markdown
Member

Fresh PR with just the waveshare changes, unlike #5660

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added official release support for the Waveshare ESP32-S3 (32MB) with HUB75 LED display interface, including Audio Reactive effects and SD card support.
  • Chores

    • Expanded the release automation/build matrix to include an additional Waveshare hardware environment for publishing tagged releases.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 62927195-4d04-4402-95ca-0dd3a8422ce6

📥 Commits

Reviewing files that changed from the base of the PR and between 857b314 and cb2dff8.

📒 Files selected for processing (1)
  • platformio.ini
🚧 Files skipped from review as they are similar to previous changes (1)
  • platformio.ini

Walkthrough

The waveshare_esp32s3_32MB_hub75 PlatformIO environment in platformio.ini is expanded with explicit hardware pin definitions (button, I2C, ES8311 audio/I2S, SD SPI), the Internal_Temperature and AudioReactive usermods, and enabled SD SPI flags. The same environment is added to the release CI build matrix template.

Changes

Waveshare ESP32-S3 HUB75 Environment Expansion

Layer / File(s) Summary
Environment build flags, usermods, and release matrix
platformio.ini, .github/platformio_release.ini.template
[env:waveshare_esp32s3_32MB_hub75] replaces the minimal build_flags (removing ${hub75.i2s_disable_flags}) with explicit WAVESHARE_S3_PINOUT, BTNPIN, I2C, ES8311 audio/I2S, and UM_SD_* SPI pin macros; enables -D WLED_USE_SD_SPI and -D SD_PRINT_HOME_DIR; sets custom_usermods to Internal_Temperature and the AudioReactive usermod via a pinned Git commit. The environment is also added to default_envs in the release CI template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • wled/WLED#5558: Introduced the release template/workflow gating for HUB75 envs — this PR directly extends that matrix by adding waveshare_esp32s3_32MB_hub75.
  • wled/WLED#5657: Previously introduced the WAVESHARE_S3_PINOUT hardware pinout symbol that this PR's build flags depend on.
  • wled/WLED#5514: Related AudioReactive usermod enablement in PlatformIO environments, matching this PR's addition of the AudioReactive usermod via custom_usermods.

Suggested labels

usermod, hardware, enhancement

Suggested reviewers

  • DedeHai
  • softhack007
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'waveshare_esp32s3_32MB_hub75 - audio support' clearly and concisely summarizes the main objective of the pull request: adding audio support to the specific Waveshare ESP32-S3 board variant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netmindz netmindz marked this pull request as ready for review June 20, 2026 14:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platformio.ini`:
- Around line 798-799: The build_unflags variable reference on line 798 uses
incorrect PlatformIO interpolation syntax with the env: prefix. In PlatformIO,
the env: prefix is reserved for system environment variables, not for
cross-environment section references. Change the interpolation syntax from
${env:esp32S3_wroom2_32MB.build_unflags} to ${esp32S3_wroom2_32MB.build_unflags}
by removing the env: prefix to properly reference the parent environment's
build_unflags variable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdeb94a6-1a23-4480-b42d-facd8a80a8c2

📥 Commits

Reviewing files that changed from the base of the PR and between 360853b and 5806abc.

📒 Files selected for processing (2)
  • .github/platformio_release.ini.template
  • platformio.ini

Comment thread platformio.ini
Comment thread platformio.ini
; -D SD_PRINT_HOME_DIR
-D BTNPIN=0
-D I2CSDAPIN=47 -D I2CSCLPIN=48
-D SR_DMTYPE=9 -D I2S_SDPIN=39 -D I2S_CKPIN=43 -D I2S_WSPIN=38 -D MCLK_PIN=12 ; Waveshare ES8311 Codec pins

@softhack007 softhack007 Jun 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmtype=9 (ES8311) is only supported in the WLED-MM (out-of-tree) variant of audioreactive. maybe add a comment to clarify this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is exactly what this env is building against ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants