Update index.html added scroll to top button#68
Open
sempijja wants to merge 1 commit intowkambale:mainfrom
Open
Update index.html added scroll to top button#68sempijja wants to merge 1 commit intowkambale:mainfrom
sempijja wants to merge 1 commit intowkambale:mainfrom
Conversation
I earlier saw a suggestion to add pagination, though it could improve a couple of things this is a "wall" and should be treated as such without pages. Changes can be made to the button in case before deployment
Owner
|
@Musacoli, there's an interesting bit here about pagination. and i think i agree with this perspective. this a wall, not a website. |
Collaborator
Fair point with that, though we might also want to consider the bandwidth strain of having no pagination, at least we could use lazy loading versus numbered pagination, that way we maintain a wall and also reduce the weight of the initial loading experience. Almost like this #66 |
Collaborator
|
please could you just resolve the errors there, I like the idea of infinite scrolling with lazy loading |
Collaborator
|
@sempijja please update the PR with the latest changes and we'll test and provide feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I earlier saw a suggestion to add pagination, though it could improve a couple of things this is a "wall" and should be treated as such without pages. Changes can be made to the button in case before deployment