-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[next]: astro/zod #12815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next]: astro/zod #12815
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better than the PR I was afraid this was going to be, Zod 4. 😅
Some notes for this one:
- I added a suggestion for the upgrade guide entry
- you might have to manually deal with the fact that the experimental content collections page is removed and instead there are new content collection/reference pages to update now
- Not sure yet how to handle translations. The overall v6 content will change a lot on some pages like content collections (so we might decide that we need to remove those pages and ask for full, fresh retranslations), but not really at all on others like the actions guide where it's only this code sample that's being upated. For those, assuming the code samples will fail in v6 (i.e. this is removed entirely from our code, not just "a suggestion"), we might want to update those translations here, too.
Co-authored-by: Sarah Rainsberger <[email protected]>
Already done!
If needed I can handle translations, let me know! |
|
Yeah, looking at all of these, I would say we should find/replace everything across all languages. I think it's mostly code samples, and the few cases there is text, it is still just subbing out the location for getting Zod, not changing any words. Go forth and find/replace! |
|
Not as easy as search and replace unfortunately, but done! |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made two slight editing polishes to the upgrade guide, otherwise, LGTM and ready to go! 🚀 (Until we meet again... in Zod 4...)
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Wait, link check is going wild... |
|
The link checker is broken but I don't think it's specific to this PR? |
|
It's weird, because the v6 PR itself is fine and I think this PR is updated to that? Let's see what happens on this next link check run |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, checks magically pass now, so I guess we're good!
Description (required)
Related issues & labels (optional)
For Astro version:
6.0. See astro PR #14923.