Conversation
Contributor
|
@curdbecker can you please fix the lint issue (see checks) |
480aa3a to
574ad84
Compare
Collaborator
Author
|
@b3n3d1k7 Sure, fixed :) |
a315a86 to
67ee4ff
Compare
TLVs in ecrterm are broken beyond belief... I had to enable Pycharm debugging flags just to not crash the Python debugger :-/
67ee4ff to
44878c5
Compare
Collaborator
Author
|
@b3n3d1k7 Also added the TLVs for ZVT card type id and application label/id... Not that useful unfortunately, since TLV construction in ecrterm is still horribly broken and I gave up trying to fix it. That's just a mess. However, they still make sense in ecrterm and we don't need to have two separate releases with trivial changes, so I put it also in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.