Skip to content

Support for requesting an explicit diagnosis type + Support for (common) card type ids + application label/id#19

Merged
b3n3d1k7 merged 2 commits intopy3from
feature/support-for-requesting-an-explicit-diagnosis-type
Dec 8, 2025
Merged

Support for requesting an explicit diagnosis type + Support for (common) card type ids + application label/id#19
b3n3d1k7 merged 2 commits intopy3from
feature/support-for-requesting-an-explicit-diagnosis-type

Conversation

@curdbecker
Copy link
Copy Markdown
Collaborator

No description provided.

@b3n3d1k7
Copy link
Copy Markdown
Contributor

b3n3d1k7 commented Dec 4, 2025

@curdbecker can you please fix the lint issue (see checks)

@curdbecker curdbecker force-pushed the feature/support-for-requesting-an-explicit-diagnosis-type branch from 480aa3a to 574ad84 Compare December 7, 2025 17:17
@curdbecker
Copy link
Copy Markdown
Collaborator Author

@b3n3d1k7 Sure, fixed :)

@curdbecker curdbecker marked this pull request as draft December 7, 2025 20:36
@curdbecker curdbecker force-pushed the feature/support-for-requesting-an-explicit-diagnosis-type branch 2 times, most recently from a315a86 to 67ee4ff Compare December 8, 2025 02:43
TLVs in ecrterm are broken beyond belief... I had to enable Pycharm
debugging flags just to not crash the Python debugger :-/
@curdbecker curdbecker force-pushed the feature/support-for-requesting-an-explicit-diagnosis-type branch from 67ee4ff to 44878c5 Compare December 8, 2025 02:45
@curdbecker curdbecker changed the title Support for requesting an explicit diagnosis type Support for requesting an explicit diagnosis type + Support for (common) card type ids + application label/id Dec 8, 2025
@curdbecker curdbecker marked this pull request as ready for review December 8, 2025 02:46
@curdbecker
Copy link
Copy Markdown
Collaborator Author

@b3n3d1k7 Also added the TLVs for ZVT card type id and application label/id... Not that useful unfortunately, since TLV construction in ecrterm is still horribly broken and I gave up trying to fix it. That's just a mess.

However, they still make sense in ecrterm and we don't need to have two separate releases with trivial changes, so I put it also in this PR.

@b3n3d1k7 b3n3d1k7 merged commit db34e36 into py3 Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants