Wpb 17321 enable demo cd #828
Conversation
sghosh23
left a comment
sghosh23
left a comment
There was a problem hiding this comment.
The PR looks good to me, have some clarification questions and some suggestions.
May be adding a tag based workflow not to deploy the demo on every commit/PR would be helpful.
offline/cd_demo.sh
Outdated
| yq eval -i ".wiab.hosts.deploy_node.ansible_ssh_private_key_file = \"${INVENTORY_DIR}/ssh_private_key\"" "${INVENTORY_FILE}" | ||
| yq eval -i ".wiab.vars.artifact_hash = \"$COMMIT_HASH\"" "${INVENTORY_FILE}" | ||
| yq eval -i ".wiab.hosts.deploy_node.ansible_user = \"$TEST_USER\"" "${INVENTORY_FILE}" | ||
| cat "${INVENTORY_DIR}/ssh_private_key" |
There was a problem hiding this comment.
Is it intentional to print private_key, I would assume it was for test purpose
There was a problem hiding this comment.
yes, let me remove it
| # A new WIAB (wire in a box) dev solution has been created https://docs.wire.com/latest/how-to/install/demo-wiab.html and can be used until this (wiab-staging) gets updated | ||
| name: Deploy on Hetzner WIAB setup | ||
| on: | ||
| workflow_run: |
There was a problem hiding this comment.
The workflow has nothing here. Should this file be part of the PR?
There was a problem hiding this comment.
The comment is meant to highlight that there was an old solution which is not to be confused with current wiab-demo.
| @@ -1,3 +1,5 @@ | |||
| # This playbook is not-up-to-date, requires to be updated to match with current developments | |||
| # A new WIAB (wire in a box) dev solution has been created https://docs.wire.com/latest/how-to/install/demo-wiab.html and can be used until this (wiab-staging) gets updated | |||
There was a problem hiding this comment.
Please elaborate the comments, is it relevant to this PR and update?
There was a problem hiding this comment.
Earlier we used to have a Wire in a box (staging) environment and we used to use this playbook to deploy it. Now we have another wiab (demo/dev) environment and this comment is to say that, we haven't updated the other wiab(staging) solution yet, so users can use the wiab-demo in the meantime.
|
|
||
| # shellcheck disable=SC2087 | ||
|
|
||
| # This script can be replaced with a simpler solution of wiab-demo installtion |
There was a problem hiding this comment.
Comments? If the script needs to be touched in another PR mention that please. Just comments is a bit confusing here
There was a problem hiding this comment.
this PR is trying to remove the confusion between old wiab staging and current wiab-demo one
| @@ -0,0 +1,2 @@ | |||
| Added: enable cd-demo.sh to verify the demo-wiab builds | |||
There was a problem hiding this comment.
Is it verifying or running an actual deployment?
There was a problem hiding this comment.
it will verify the changes for wiab-demo via deploying it
There was a problem hiding this comment.
I would rephrase it as Added: cd-demo.sh to deploy and verify the demo-wiab builds
|
* enable: wpb-17321 refactor and fixes for wiab-demo, added all changes in changelog * fix: create a new tag for wire_secrets and handle errors from zauth wpb-17321 * fix wpb-17321: made wire_secrets playbook idempotent * fix wpb-17321: handle wire-utility deploy issues and update documentation for demo-wiab * Update changelog.d/3-deploy-builds/demo-wiab-ansible-fixes Co-authored-by: Sukanta <[email protected]> * Update changelog.d/3-deploy-builds/demo-wiab-ansible-fixes Co-authored-by: Sukanta <[email protected]> * fix wpb-17321: parameterize y-go version in install_pkgs playbook * fix wpb-17321: change http check to netcat based check in hairpin networking * fix wpb-17321: refactor offline_deploy_k8s.sh to work with envs and update wire_values accoordingly * fix wpb-17321: refactor wire_secrets to be idempotent and move all secret management to it * fix wpb-17321: when conditions in deploy_wiab to better manage common tasks for minikube networking * fix wpb-17321: cert-manager deploy control with cert_manager_networking tag * fix wpb-17321: update the documentation for demo-wiab * fix wpb-17321: added minio secrets in demo-values and removed extra BASE_DIR in wire_values * fix wpb-17321: move away from yq-go to ansible native yaml updates and added minio creds * fix wpb-17321: fix basc script suggestions from sonarcloud * fix wpb-17321: fix wire_secrets for cargohold * fix wpb-17321: fix wire_secrets for fake-aws-s3 * fix wpb-17321: fix clean_cluster permissions * fix: wpb-17321 add coturn empty values file, ignore the download task file permissions error * fix: wpb-17321 fix wire_secrets for non-prepared secrets, fixed flow using tags in deploy_wiab and update the documentation * Wpb 17321 enable demo cd (#828) * enable: wpb-17321 add terraform and bash scripts to enable cd-demo * enable: wpb-17321 added changelog and a note to old wiab-staging scripts * fix: wpb-17321 remove the debugging statements from cd-demo.sh --------- Co-authored-by: Sukanta <[email protected]>
Change type
Basic information
Testing
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case