Skip to content

[DO NOT MERGE] add examples values for roman #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] add examples values for roman #597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3619867
add examples values for roman postgresql13-ephemeral
amitsagtani97 Jan 5, 2023
3373f12
removed postgres example values
amitsagtani97 Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions values/roman/prod-values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
roman:
replicaCount: 1
image:
repository: quay.io/wire/roman
# Overrides the image tag whose default is the chart appVersion.
tag: staging
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really not have a production tag for this?

serviceToken: # Provide the roman service token.
# randomly generated for local testing
appKey: b53181dd-6400-4960-8988-f775545588ff-0949f503-421e-4588-a2c5-f64fd9c180fd
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and how is the user supposed to randomly generate this?

wireApiHost: https://nginz-https.example.com
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is totally wrong. look at the prod-values.example.yaml . when referring to a wire component, we don't use FQDNs.

proxyDomain:
# random base 64 string used as certificate, replace with real one
pubKeyBase64: LS0tLS1CRUdJTiBQVcFQvWjcKMlczd1A1TzJveFVCTElDIEtFWS0tLS0tCg==
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, how is a user supposed to use this, and.. what kind of cert is this?

publicURL: roman.example.com # Link to the subdomain pointing to roman.
dbURL: jdbc:postgresql://postgresql:5432/externalPostgresql # Link to your Postgres server.
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should point to the ephemeral postgres, by default.

dbUser: externalPostgresql # Provide your Postgres DB username.
dbPassword: externalPostgresql # Provide your Postgres DB password.

tls:
Copy link
Member

@julialongtin julialongtin Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to supply certificates other than letsEncrypt?

issuerRef:
name: letsencrypt-http01