Skip to content

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Nov 12, 2025

TaskWPB-21606 [Android] Display tags by alphabetical order


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Display tags by alphabetical order
  • Copies update

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested a review from saleniuk November 17, 2025 13:59
…er' into Display-tags-by-alphabetical-order

# Conflicts:
#	features/cells/src/main/res/values/strings.xml
@pull-request-size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@ohassine ohassine enabled auto-merge November 17, 2025 15:18
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 52.01794% with 214 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.42%. Comparing base (fa77b9e) to head (70358be).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...e/android/ui/home/gallery/MediaGalleryViewModel.kt 56.48% 43 Missing and 4 partials ⚠️
...s/participants/GroupConversationParticipantList.kt 0.00% 16 Missing and 1 partial ⚠️
...s/participants/model/ParticipantsExpansionState.kt 0.00% 15 Missing ⚠️
...rsations/attachment/MessageAttachmentsViewModel.kt 0.00% 13 Missing ⚠️
...e/conversations/search/apps/SearchAppsViewModel.kt 0.00% 13 Missing ⚠️
.../wire/android/mapper/SystemMessageContentMapper.kt 0.00% 11 Missing and 1 partial ⚠️
...dia/audiomessage/ConversationAudioMessagePlayer.kt 45.45% 7 Missing and 5 partials ⚠️
...nversations/edit/MessageOptionsModalSheetLayout.kt 0.00% 12 Missing ⚠️
...android/media/audiomessage/AudioWavesMaskHelper.kt 55.00% 4 Missing and 5 partials ⚠️
...ails/updateappsaccess/UpdateAppsAccessViewModel.kt 91.11% 5 Missing and 3 partials ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4407      +/-   ##
===========================================
+ Coverage    47.28%   47.42%   +0.14%     
===========================================
  Files          532      537       +5     
  Lines        17743    18000     +257     
  Branches      3006     3048      +42     
===========================================
+ Hits          8389     8536     +147     
- Misses        8461     8549      +88     
- Partials       893      915      +22     
Files with missing lines Coverage Δ
...ndroid/media/audiomessage/AudioMessageViewModel.kt 87.50% <100.00%> (ø)
...tions/details/GroupConversationDetailsViewModel.kt 82.07% <100.00%> (+2.07%) ⬆️
...s/details/options/GroupConversationOptionsState.kt 96.96% <100.00%> (+2.68%) ⬆️
...participants/model/ConversationParticipantsData.kt 100.00% <100.00%> (ø)
.../details/updateappsaccess/UpdateAppsAccessState.kt 100.00% <100.00%> (ø)
...e/conversations/messages/item/SystemMessageItem.kt 0.00% <ø> (ø)
...versations/messages/preview/PreviewMessageTypes.kt 0.00% <ø> (ø)
...android/ui/home/conversations/model/AssetBundle.kt 50.00% <100.00%> (+2.38%) ⬆️
...ndroid/ui/home/conversations/model/MessageTypes.kt 80.95% <ø> (ø)
...messagetypes/multipart/MultipartAttachmentsView.kt 0.00% <ø> (ø)
... and 35 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa77b9e...70358be. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine added this pull request to the merge queue Nov 17, 2025
Merged via the queue into develop with commit cd7535d Nov 17, 2025
16 of 17 checks passed
@ohassine ohassine deleted the Display-tags-by-alphabetical-order branch November 17, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants