-
Notifications
You must be signed in to change notification settings - Fork 42
feat: add background notification retry logic with configurable stayalive duration #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@claude review |
|
🤖 Beep boop! Claude is putting on their reading glasses and diving into your code... ⏳ This comment will be updated with the review results once I'm done pondering the mysteries of your implementation. In the meantime, feel free to grab a coffee ☕ - reviewing code is serious business! |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (7.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4391 +/- ##
===========================================
- Coverage 47.13% 47.03% -0.10%
===========================================
Files 531 531
Lines 17651 17686 +35
Branches 2988 2995 +7
===========================================
Hits 8319 8319
- Misses 8444 8478 +34
- Partials 888 889 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
sometimes it can happen that the work manager for notifications starts, but the app does not have internet access.
Causes (Optional)
not sure why the system is blocking internet access
Solutions
have wm wait for internet access to start running
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.