feat: add service key authentication for registration #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional X-Service-Key header authentication to the registration module, enabling services to register with orchestrators that require authentication. - Add service_key and service_key_env parameters to with_registration() - Include X-Service-Key header in register, keepalive, and deregister requests - Default env var: SERVICEKIT_REGISTRATION_KEY - Direct parameter takes precedence over environment variable - Backwards compatible: no header sent if key not configured - Bump version to 0.7.0
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
X-Service-Keyheader authentication to the registration moduleservice_keyandservice_key_envparameters to.with_registration()X-Service-Keyheader in register, keepalive, and deregister requestsTest plan
make lintpassesmake testpasses (all 359 tests pass)