Repository navigation
docs: note callbacks=false and declare-time checks for dependent= - #4455
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
Review: head 2030aee. APPROVE (docs), with one LOW.
LOW: "surfaces at app start". Wheels doesn't load models at application start ( The final follows PR CI (plus the LOW, if you take it). |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
FINAL: APPROVE (recorded after merge). Head c8814f1. Docs only: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #4394 in the consumer
models.md(and itswheels newtemplate copy). One line in thedependent=section:callbacks=false:delete(callbacks=false)on the parent now skips the dependents' callbacks too (model/associations.cfmpassescallbacksto every dependent call).dependentvalue throwsWheels.InvalidArgumentwhen the association is declared ($validateDependent), not on the first delete.tools/build/scripts/ship-consumer-docs.sh checkpasses, and the template copy is identical.🤖 Generated with Claude Code