Skip to content

Editorial: use CreateBuiltinFunction for more built-in function objects - #1612

Merged
annevk merged 2 commits into
mainfrom
annevk/createbuiltinfunction
Jun 26, 2026
Merged

Editorial: use CreateBuiltinFunction for more built-in function objects#1612
annevk merged 2 commits into
mainfrom
annevk/createbuiltinfunction

Conversation

@annevk

@annevk annevk commented Jun 22, 2026

Copy link
Copy Markdown
Member

This is a bit clearer and more explicit than having the separate paragraphs afterwards. It also makes the arguments clear upfront.


Preview | Diff

This is a bit clearer and more explicit than having the separate paragraphs afterwards. It also makes the arguments clear upfront.
Comment thread index.bs Outdated
* The value of the property is a [=built-in function object=]
that behaves as follows when invoked:
* The value of the property is the [=built-in function object=] [$CreateBuiltinFunction$](|getSteps|, 1, "<code>get</code>", « »),
where |getSteps| is the following algorithm taking one argument |keyArg|:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like bikeshed is complaining because it does not see this keyArg defined here and then used in the algorithm.

@Ms2ger Ms2ger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible, thanks

@annevk
annevk merged commit 9769865 into main Jun 26, 2026
2 checks passed
@annevk
annevk deleted the annevk/createbuiltinfunction branch June 26, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants