Skip to content

Navigation: Add optimization to ignore duplicate navigations #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Navigation: Add optimization to ignore duplicate navigations #11765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31672e3
feat(navigation): Ignore duplicate navigations
llannasatoll Oct 8, 2025
4d255eb
Refine duplicate navigation check
llannasatoll Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 63 additions & 4 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11566,10 +11566,21 @@ partial interface <dfn id="document" data-lt="">Document</dfn> {
the user agent must do nothing. Otherwise, if the <code>Document</code>'s <span
data-x="concept-document-origin">origin</span> is an <span data-x="concept-origin-opaque">opaque
origin</span>, the user agent must throw a <span>"<code>SecurityError</code>"</span>
<code>DOMException</code>. Otherwise, the user agent must act as it would when <span
data-x="receives a set-cookie-string">receiving a set-cookie-string</span> for the document's
<span data-x="concept-document-url">URL</span> via a "non-HTTP" API, consisting of the new value
<span data-x="utf-8 encode">encoded as UTF-8</span>. <ref>COOKIES</ref> <ref>ENCODING</ref></p>
<code>DOMException</code>. Otherwise:</p>

<ol>
<li>
<p>Set this <code>Document</code>'s <span>navigable</span>'s <span>navigation conditions potentially changed</span> to true.</p>
<p class="note">Other operations that could set cookies, such as the <a href="https://wicg.github.io/cookie-store/">Cookie Store API</a> or receiving a Set-Cookie header in a fetch response, also cause the <span>navigation conditions potentially changed</span> to be set to true.</p>
</li>

<li><p>The user agent must act as it would when <span
data-x="receives a set-cookie-string">receiving a set-cookie-string</span> for the document's
<span data-x="concept-document-url">URL</span> via a "non-HTTP" API, consisting of the new value
<span data-x="utf-8 encode">encoded as UTF-8</span>. <ref>COOKIES</ref> <ref>ENCODING</ref></p>
</li>

</ol>
</div>

<p class="note">Since the <code data-x="dom-document-cookie">cookie</code> attribute is accessible
Expand Down Expand Up @@ -103073,6 +103084,11 @@ interface <dfn interface>NotRestoredReasons</dfn> {

<p class="note">This is only ever set to true in cases where the navigable's <span
data-x="nav-parent">parent</span> is non-null.</p>
</li>

<li>
<p>A <dfn>navigation conditions potentially changed</dfn> boolean, initially false.</p>
</li>
</ul>

<p>The <span data-x="nav-current-history-entry">current session history entry</span> and the
Expand Down Expand Up @@ -106305,6 +106321,49 @@ location.href = '#foo';</code></pre>
data-x="apply the traverse history step">traversing</span> are ignored.</p>
</li>

<li>
<p>If <var>navigable</var>'s <span>ongoing navigation</span> is not null, and all of the following
are true:</p>

<ul>
<li>
<p>the time elapsed since the ongoing navigation was initiated is within a
user-agent-defined threshold;</p>
</li>
<li>
<p>both the new and ongoing navigations are HTTP GET requests, and the new navigation is not
a form submission;</p>
</li>
<li>
<p>the navigations have an identical <var>url</var>, <span
data-x="document-state-initiator-origin">initiator origin</span>, <span
data-x="document-state-request-referrer">referrer</span>, <span
data-x="document-state-request-referrer-policy">request referrer policy</span>,
<var>userInvolvement</var>, and <var>historyHandling</var>;</p>
</li>
<li>
<p>the <var>navigable</var>'s <span>navigation conditions potentially changed</span> is false,</p>
</li>
</ul>
<p>then:</p>

<ol>
<li>
<p>Invoke <span>WebDriver BiDi navigation failed</span> with <var>navigable</var> and a new
<span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>.</p>
</li>
<li><p>Return.</p></li>
</ol>
</li>

<li>
<p>Set <span>navigable</span>'s <span>navigation conditions potentially changed</span> to false.</p>
</li>

<li>
<p><span>Set the ongoing navigation</span> for <var>navigable</var> to
<var>navigationId</var>.</p>
Expand Down