This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Update dependencies and fix clippy lints#84
Open
barafael wants to merge 4 commits intowhatisinternet:masterfrom
Open
Update dependencies and fix clippy lints#84barafael wants to merge 4 commits intowhatisinternet:masterfrom
barafael wants to merge 4 commits intowhatisinternet:masterfrom
Conversation
|
I wouldn't just call this "low hanging fruit." Some of these fix actual warnings, and currently the crate does not compile due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does:
Hopefully nothing! Just improved mostly the string handling, removed some unneeded clones etc.
Why it does it:
Cuz... low hanging fruit for code quality? You be the judge.