Skip to content

fix: top up sessions before signing credentials - #687

Merged
brendanjryan merged 1 commit into
wevm:mainfrom
parvahuja:fix/session-fetch-top-ups
Jul 23, 2026
Merged

fix: top up sessions before signing credentials#687
brendanjryan merged 1 commit into
wevm:mainfrom
parvahuja:fix/session-fetch-top-ups

Conversation

@parvahuja

@parvahuja parvahuja commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Fixes automatic Tempo session top-ups before credentials are signed.

  • uses one shared pre-sign hook for HTTP, SSE, and WebSocket
  • applies topUpAmount, then bounded suggestedDeposit, then the exact shortfall
  • retries management credentials against refreshed TIP-1034 challenges
  • excludes closing channels from recovery

Supersedes #688.

Validation

  • 231 focused session tests
  • 38 focused Fetch 402 retry tests
  • pnpm check:ci
  • pnpm check:types
  • pnpm check:types:html
  • pnpm check:types:examples
  • pnpm build

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/mppx@687

commit: 3da3446

@parvahuja parvahuja changed the title fix: top up fetch sessions before vouchers fix: top up sessions before signing credentials Jul 22, 2026
@parvahuja
parvahuja force-pushed the fix/session-fetch-top-ups branch 3 times, most recently from 496b332 to 2c3aebe Compare July 22, 2026 21:37
@parvahuja
parvahuja marked this pull request as ready for review July 22, 2026 21:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c3aebed13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tempo/session/client/SessionManager.ts Outdated
@parvahuja
parvahuja force-pushed the fix/session-fetch-top-ups branch from 2c3aebe to 7eccd63 Compare July 22, 2026 22:41
@parvahuja

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 7eccd63c84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parvahuja
parvahuja force-pushed the fix/session-fetch-top-ups branch from 7eccd63 to 23f80b7 Compare July 23, 2026 00:21
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
@parvahuja
parvahuja force-pushed the fix/session-fetch-top-ups branch from 23f80b7 to 3da3446 Compare July 23, 2026 17:00
@brendanjryan
brendanjryan merged commit 8935947 into wevm:main Jul 23, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants