fix: reject empty challenge ids#570
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
commit: |
Collaborator
|
@EfeDurmaz16 -- can you sign your commits? |
EfeDurmaz16
force-pushed
the
fix/non-empty-challenge-id
branch
from
e2499b3 to
ff86589
Compare
Author
|
oops, signed now @brendanjryan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id: ""as an invalid explicit ID infromMethod()instead of falling back tosecretKey.This aligns mppx with the spec/conformance tightening discussed in tempoxyz/mpp-tools#19 (comment).
Verification
VITE_TEMPO_NETWORK=none pnpm exec vp test --project node src/Challenge.test.tsVITE_TEMPO_NETWORK=none pnpm check:typesVITE_TEMPO_NETWORK=none pnpm check:ci