fix(email): reinforcement of the validator and skip invalid address when sending alerts #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen sending alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
On the last version for Sylius 1.X, version 4.1.0, we had a bug blocking the sending of alerts.
Indeed, if the email format was incorrect, we had an RfcComplianceException.
A person try an injection with this kind of email :
[email protected]'&&sleep(27*1000)*ckfqsx&&'just by changing the input type from email to text, the backend Email validator accept this email.To prevent that I add it the redtriction mode :
Email::VALIDATION_MODE_STRICTOn alert sending, I had a try catch to no stop alert sending on email error.
If you accept this PR, can we have an 4.1.1 or 4.2.0 tags for Sylius 1 pls ?
Have a nice day !
Kind regards,
Kévin