[Maintenance] Bump plugin to Sylius 1.14 #76
Conversation
lruozzi9
requested review from
LucaGallinari,
Copilot,
lamasfoker,
lruozzi9 and
mmenozzi
There was a problem hiding this comment.
Pull Request Overview
This PR updates the plugin's compatibility from Sylius 1.12 to Sylius 1.14. The main changes include migrating from a custom test application structure to using Sylius's new test application package, updating PHP version requirements, and modernizing the build configuration.
- Replaced custom test application with
sylius/test-applicationpackage - Updated Sylius version requirement from
^1.12to^1.14 - Updated minimum PHP version from
8.0to8.1
Reviewed Changes
Copilot reviewed 96 out of 111 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated Sylius dependency to ^1.14, added sylius/test-application package, and updated PHP version to 8.1 |
| phpunit.xml.dist | Updated bootstrap path and kernel class to use new test application |
| behat.yml.dist | Updated configuration paths to use new test application structure |
| README.md | Updated installation instructions and requirements documentation |
| .github/workflows/build.yml | Modernized CI workflow for Sylius 1.14 compatibility |
| Multiple test application files | Removed entire custom test application structure in favor of shared package |
| tests/TestApplication/* | Added new test application configuration files for Sylius 1.14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sylius.shop.layout.after_body: | ||
| blocks: | ||
| webgriffe_bisn_add_javascript: '@WebgriffeSyliusBackInStockNotificationPlugin/_javascript.html.twig' |
There was a problem hiding this comment.
This would be probably a BC, why you have removed it already in 1.14?
There was a problem hiding this comment.
You're right, I'll roll it back
There was a problem hiding this comment.
Also this file should not be removed here?
Wojdylak
force-pushed
the
upgrade-1-14
branch
from
091816d to
02554a3
Compare
Wojdylak
force-pushed
the
upgrade-1-14
branch
from
02554a3 to
5d977f2
Compare
2 participants
No description provided.