Skip to content

feat(editor): add 3× and 4× playback speed options#101

Open
PALConverteo wants to merge 1 commit intowebadderall:mainfrom
PALConverteo:feat/playback-speed-x4
Open

feat(editor): add 3× and 4× playback speed options#101
PALConverteo wants to merge 1 commit intowebadderall:mainfrom
PALConverteo:feat/playback-speed-x4

Conversation

@PALConverteo
Copy link

@PALConverteo PALConverteo commented Mar 24, 2026

Summary

  • Extend PlaybackSpeed type to include 3 and 4
  • Add 3× and 4× entries to SPEED_OPTIONS in the settings panel
  • Update speed validation in project persistence to accept the new values

No technical limitation — HTML5 playbackRate and AudioContext handle these speeds natively.

Test plan

  • Open a project, add a speed region, verify 3× and 4× appear in the dropdown
  • Set a region to 4×, play back, confirm video and audio play at correct speed
  • Export a video with a 4× speed region, verify output is correct
  • Save/reload a project with 3× or 4× regions, confirm they persist

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features

  • Added support for 3x and 4x playback speeds in the video editor. Users can now select from an expanded range of playback speeds, with the maximum speed increased from 2x to 4x for customized viewing experiences.

Extend playback speed range beyond 2× to support faster preview.
HTML5 playbackRate and AudioContext both handle these speeds natively.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "*" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b6279801-0487-4326-993a-1da9b4c15ef9

📥 Commits

Reviewing files that changed from the base of the PR and between 6e69da0 and 067ae7f.

📒 Files selected for processing (2)
  • src/components/video-editor/projectPersistence.ts
  • src/components/video-editor/types.ts

📝 Walkthrough

Walkthrough

The playback speed feature is expanded to support higher speeds (3× and 4×). Type definitions and speed options are updated, and the project normalization logic is modified to preserve these new speeds during persistence operations.

Changes

Cohort / File(s) Summary
Playback Speed Expansion
src/components/video-editor/types.ts, src/components/video-editor/projectPersistence.ts
Extended PlaybackSpeed type union to include 3 and 4, added corresponding entries to SPEED_OPTIONS, and updated normalization logic to preserve the new speed values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Three times fast, four times too,
The rabbit hopped right through,
New speeds bloom in the editor's view,
Types and logic aligned anew! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description covers the key changes and includes a test plan, though it does not follow the provided template structure with labeled sections like 'Motivation', 'Type of Change', or 'Related Issue(s)'. Restructure the description to match the repository template by adding explicit sections: 'Motivation', 'Type of Change' checkbox selection, 'Related Issue(s)', and standard 'Checklist' items.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main feature being added: support for 3× and 4× playback speed options in the editor.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@webadderall
Copy link
Owner

Could you please attach a screenshot? I'm not sure if the spacing will look pleasing after this addition

@PALConverteo
Copy link
Author

Here is a screenshot

image

@webadderall
Copy link
Owner

webadderall commented Mar 25, 2026

I would like the controls to be on 1 row if possible. You could try any approach you think would look make the playback speed controls look good, but I would suggest getting rid of 0.25x and 1.75x to make space for 3x and 4x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants