Conversation
Following issue has been reported by a user of the extension: ``` Core: Exception handler (WEB): Uncaught TYPO3 Exception: WebVision\DeeplWrite\Domain\Enum\RephraseSupportedDeepLLanguage::tryFrom(): Argument #1 ($language) must be of type string, null given, called in vendor/web-vision/deepl-write/Classes/Service/LanguageService.php on line 18 | TypeError thrown in file vendor/web-vision/deepl-write/Classes/Domain/Enum/RephraseSupportedDeepLLanguage.php in line 59. Core: Error handler (BE): PHP Warning: Undefined array key "deeplWriteLanguage" in vendor/web-vision/deepl-write/Classes/Service/LanguageService.php line 16 ``` In case the language configuration in the SiteConfig has not been done yet the array key does not exists and the current code tries to access the array with a key not existing in the array, honered with the above error and exception. The array access is now guarded using `null-coalsce` fallback in the `LangaugeService` and also ensuring that the result is really a string, falling back to an empty string and mitigates the issue. Functional tests have been added to cover the `LanguageService` and one test specifically added for the above mentioned issue failes if the change to fix the issue is reverted. > [!IMPORTANT] > Functional test infrastructure for this package not in place > yet and not active in github action workflow. Will be done > in a dedicated change. However, added tests works using the > functional test of the private deepltranslate root development > setup (internally).
torben-fr
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following issue has been reported by a user of the extension:
In case the language configuration in the SiteConfig has not been
done yet the array key does not exists and the current code tries
to access the array with a key not existing in the array, honered
with the above error and exception.
The array access is now guarded using
null-coalscefallback inthe
LangaugeServiceand also ensuring that the result is reallya string, falling back to an empty string and mitigates the issue.
Functional tests have been added to cover the
LanguageServiceand one test specifically added for the above mentioned issue
failes if the change to fix the issue is reverted.
Important
Functional test infrastructure for this package not in place
yet and not active in github action workflow. Will be done
in a dedicated change. However, added tests works using the
functional test of the private deepltranslate root development
setup (internally).