Rescue from connection refused errors and return the appropriate status code#42
Open
andrewhavens wants to merge 1 commit intowaterlink:masterfrom
Open
Conversation
Owner
|
@andrewhavens Great work here! How do you plan to test this feature? |
Author
|
@waterlink hmm...I'm not sure. I can't remember exactly how it's triggered. Somewhere in Rack I think. I suppose we could mock the error. What do you think? |
Owner
|
@andrewhavens We could try to use webmock and raise the error inside of the Also, I have noticed that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the app that is being proxied is not running, the code currently returns an exception. This prevents the exception and returns the appropriate status code.