Skip to content

Adding DockerFile#3

Open
wasimakhtarcnx wants to merge 1 commit intomasterfrom
first-action
Open

Adding DockerFile#3
wasimakhtarcnx wants to merge 1 commit intomasterfrom
first-action

Conversation

@wasimakhtarcnx
Copy link
Owner

Adding DockerFile

Adding DockerFile
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Adding DockerFile

Powered by Pull Assistant. Last update 4c86d40 ... 4c86d40. Read the comment docs.

@github-learning-lab
Copy link

Nice work, you committed a Dockerfile. You'll notice at the end of the Dockerfile, we refer to an entrypoint script.

ENTRYPOINT ["/entrypoint.sh"]

The entrypoint.sh script will be run in Docker, and it will define what the action is really going to be doing.

Step 2: Add the action's script

An entrypoint script must exist in our repository so that Docker has something to execute.

⌨️ Activity: Add an entrypoint script and commit it to your branch

  1. As a part of this branch and pull request, create a file in the ./action-a/ directory titled entrypoint.sh. You can do so with this quicklink
  2. Add the following content to the entrypoint.sh file:
    #!/bin/sh -l
    
    sh -c "echo Hello world my name is $MY_NAME"
  3. Stage and commit the changes
  4. Push the changes to GitHub

I'll respond when I detect a new commit on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant