Move Code editor line numbers setting to Editor and Code Review page - #15458
Draft
warp-agent-staging[bot] wants to merge 3 commits into
Draft
Move Code editor line numbers setting to Editor and Code Review page#15458warp-agent-staging[bot] wants to merge 3 commits into
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
The dropdown was previously on the Features page's Text Editing category. Move it to the Editor and Code Review sub-page alongside the other built-in code editor settings, carrying over its dropdown state, action variant, and telemetry.
Contributor
Author
|
This PR was generated with Warp. Comment |
The Editor and Code Review page only renders when FullSourceCodeEmbedding or OpenWarpNewSettingsModes is enabled; neither is in RELEASE_FLAGS, so on stable builds the setting was vanishing outright. Restore it on the Features page, gated to appear only when the destination page would not render, so it's reachable in exactly one place in either configuration.
The widget's search_terms only had the singular "number", so the
setting's own label ("line numbers") never matched. Add "numbers" to
both copies of search_terms (Features and Editor and Code Review),
keeping them identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Moves the "Code editor line numbers" dropdown setting from the Features page's "Text Editing" category to the "Editor and Code Review" sub-page (under the Code umbrella), per a Slack request from acarl005.
The setting itself is unchanged (Absolute/Relative dropdown backed by
AppEditorSettings::code_editor_line_number_mode). The dropdown'sViewHandle, its action variant (SetCodeEditorLineNumberMode), the model subscription that refreshes the dropdown's items/selection, and its telemetry event were all carried over fromFeaturesPageViewtoEditorAndCodeReviewPageView.The Editor and Code Review page only renders when
FeatureFlag::FullSourceCodeEmbeddingorFeatureFlag::OpenWarpNewSettingsModesis enabled, and neither is inRELEASE_FLAGS, so a straight move would have made the setting vanish outright on stable builds. To avoid that regression, the Features page keeps its own copy of the widget, gated to render only when the Editor and Code Review page would not be shown (!(FullSourceCodeEmbedding.is_enabled() || OpenWarpNewSettingsModes.is_enabled())) — mirroring the existingAutoOpenCodeReviewPaneWidgetdual-registration pattern already used on this page. The setting is reachable in exactly one place in either configuration, never both, never neither.Both copies'
search_termsare identical and now include both "number" and "numbers" so the setting's own label ("Code editor line numbers") matches settings search.Linked Issue
No tracked issue exists for this change; it originated directly from a Slack request.
Testing
No automated test was added — this is a UI relocation of an existing setting with no behavior change, and the repo's settings-page filter/search behavior already has coverage for the shared
PageTypemachinery this widget reuses../script/formatandcargo clippy -p warp --all-targets --tests -- -D warningsboth pass.cargo build --bin warpcompiles cleanly.FullSourceCodeEmbeddingandOpenWarpNewSettingsModesforce-disabled to simulate the stable/flags-off path:Screenshots / Videos
Computer-use video recordings
Testing Code editor line numbers dropdown persistence: Recording navigation to Settings > Code > Editor and Code Review, opening the "Code editor line numbers:" dropdown, selecting a different option, and verifying the change.
Computer-use screenshots (8)
Features settings page (flags-on default build) — the setting is absent here.
Editor and Code Review settings page (flags-on default build) showing the setting in its new home.
Dropdown options on the Editor and Code Review page (flags-on default build).
Settings sidebar with both flags force-disabled: no "Code" section/umbrella present anywhere.
Features page (flags off) showing "Code editor line numbers:" restored in its fallback location.
Features page (flags off), confirming the dropdown selection updates immediately.
Flags-on build: settings search surfaces exactly one result, under Code > Editor and Code Review.
Flags-off build: settings search surfaces exactly one result, under Features.
Agent Mode