REMOTE-2925 Add --computer-use-model to warp agent run - #15289
Draft
warp-agent-staging[bot] wants to merge 2 commits into
Draft
REMOTE-2925 Add --computer-use-model to warp agent run#15289warp-agent-staging[bot] wants to merge 2 commits into
warp agent run#15289warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Adds an agent-run override for the computer use subagent's model, so a cloud run's configuration can pick the CU model instead of always falling back to auto via the default CLI profile. The flag is Oz-harness only and beats the active execution profile, since the server dispatches --profile and --computer-use-model from the same run config snapshot. The value is forwarded verbatim to model_config.computer_use_agent rather than resolved against the locally cached CU choices: the run config is authoritative and the server validates the id, so a local resolve would silently swap a misconfigured or newly added model for the default.
Contributor
Author
|
This PR was generated with Warp. Comment |
…maining initializer The custom_endpoint_usage_display_label test builds LLMPreferences literally and was missed when the field was added, so the app test binary did not compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Adds
--computer-use-model <MODEL>towarp agent run(hidden, alongside the existing--computer-use/--no-computer-useflags) and plumbs it through agent-run setup so it overrides the AI execution profile'scomputer_use_modelwhen the client buildsmodel_config.computer_use_agentfor MAA requests.Today cloud runs use the default CLI profile, where
computer_use_modelisNone, so the computer use (CU) subagent always falls back to auto. This flag is what lets a run's configuration choose the CU model.This is the client half of a two-repo change and must land first.
warpdotdev/warp-serveronly emits--computer-use-modelfromAugmentArgsForTaskonce this flag exists in the agent build used by Warp-hosted workers; otherwise a run configured with a CU model would dispatch an unknown flag and fail at sandbox startup. Server-side work (run-config snapshot field, cloud run API field, named-agent defaults, factory-filecomputerUseModel, dispatch emission) is a separate PR inwarpdotdev/warp-server.Behavior notes:
--harnessselects a third-party harness, matching the design decision that the CU model is an Oz-harness sub-setting.--no-computer-useis accepted and simply unused, matching the server-side configuration semantics.--profileand--computer-use-modelfrom the same run-config snapshot; an override that only touched the default CLI profile would be silently dropped whenever a profile is configured.getComputerUseAgentModel), so resolving locally would silently swap a misconfigured — or newly added, not-yet-cached — model for the default.Linked Issue
REMOTE-2925 — https://linear.app/warpdotdev/issue/REMOTE-2925/factory-configurable-computer-use-model-factory-config-cloud-run-api
Testing
Automated tests cover the full chain from flag to request settings:
crates/warp_cli/src/lib_tests.rs: flag parses, trims blank values, requires a value, and coexists with--no-computer-use.app/src/ai/agent_sdk/mod_tests.rs: the parsed flag becomes the driver task'scomputer_use_modelfor Oz and is dropped for a third-party harness.app/src/ai/llms_tests.rs: the run override wins over the profile'scomputer_use_model, is forwarded verbatim even when it isn't in the cached CU choices, and leaves other surfaces and the UI-facing resolution on the profile value.app/src/ai/agent/api/impl_tests.rs:RequestParams::computer_use_modellands inmodel_config.computer_use_agent(the request-settings construction was extracted intobuild_model_configto make this assertable).Commands run in the agent sandbox:
cargo test -p warp_cli --lib computer_use— 11 passed, 0 failed.cargo clippy -p warp_cli --all-targets --all-features --tests— clean.cargo fmt -p warp -p warp_cli— clean.Not run: anything that compiles the
warpapp crate.cargo check -p warp --libis OOM-killed (SIGKILL) in this 4 GB sandbox even at-j 1, so the app-crate edits and their tests (llms_tests,mod_tests,impl_tests) are unverified locally and need CI. No manual./script/runtesting for the same reason../script/runAgent Mode