Temporarily disable PeriodicHandoffCheckpoints dogfood flag - #15286
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
Temporarily disable PeriodicHandoffCheckpoints dogfood flag#15286warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Removes FeatureFlag::PeriodicHandoffCheckpoints from DOGFOOD_FLAGS so periodic handoff checkpoints are off on all channels while the checkpoint-commit bug tracked in REMOTE-2557 is being fixed. This is a rollout toggle only: the flag variant, checkpoint_interval, the coordinator, and the pipeline all stay in place. Runs fall back to the legacy end-of-run snapshot upload path, which does not hit the failing commit_snapshot call. See https://linear.app/warpdotdev/issue/REMOTE-2557
Contributor
Author
|
This PR was generated with Warp. Comment   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporarily removes
FeatureFlag::PeriodicHandoffCheckpointsfromDOGFOOD_FLAGSso periodic handoff checkpoints are off on all channels, including dogfood, while the checkpoint-commit bug tracked in REMOTE-2557 is being fixed.This is a rollout toggle, not a feature removal: the
PeriodicHandoffCheckpointsflag variant,checkpoint_interval, the checkpoint coordinator, the pipeline, and the CLI flags all stay in place. With the flag off,app/src/ai/agent_sdk/driver.rsnever constructs thecheckpoint_coordinator, so runs fall back to the legacy end-of-runrun_snapshot_uploadpath — the only path that ever calls the failingclient.commit_snapshot(...). This removes the failing commit path while leaving end-of-run handoff snapshots working as before.The flag's doc comment is updated to note it's temporarily disabled pending the checkpoint-commit fix, pointing back at REMOTE-2557 so the next reader knows to re-add it once that issue is resolved.
Note: cloud agent runs only pick this up once they execute a dogfood build that contains this change — it has no effect on runs using an older dogfood build.
Linked Issue
Testing
cargo check -p warp_features— builds cleanly.cargo test -p warp_features— existing tests pass (local_child_harnesses_are_local_only_by_default;test_all_preview_flags_have_a_descriptionis#[ignore]d, per CORE-3768).cargo fmt -p warp_features -- --checkandcargo clippy -p warp_features --all-targets --all-features -- -D warnings— clean.Agent Mode