Make team identity window-owned - #15271
Draft
IsaiahWitzke wants to merge 5 commits into
Draft
Conversation
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Contributor
Author
|
This PR was generated with Warp. Comment |
Contributor
|
Your Warp account is not a member of any team with access to this repository. |
Co-Authored-By: Warp <agent@warp.dev>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Moves team selection out of the
UserWorkspacessingleton's mutableWindowId → team_uidmap and makes it immutable window-owned state.WindowTeam, initialized once per window.RootView,Workspace, restoration, inherited windows, detached tabs, and explicit team-switch windows.UserWorkspacesresponsible for resolving the selected UID to live team/workspace metadata.This is a direction-review draft related to the broader
X-Warp-Team-Uidwork in https://github.com/warpdotdev/warp-server/pull/14108. It does not yet attach the header to MAA requests.Linked Issue
No linked issue yet; this draft is intended to review the client ownership model before expanding the transport/server work.
ready-to-specorready-to-implement.Testing
Not run for this direction-review draft, per request.
./script/runAgent Mode
CHANGELOG-NONE