Skip to content

Make team identity window-owned - #15271

Draft
IsaiahWitzke wants to merge 5 commits into
masterfrom
warp/window-owned-team-uid
Draft

Make team identity window-owned#15271
IsaiahWitzke wants to merge 5 commits into
masterfrom
warp/window-owned-team-uid

Conversation

@IsaiahWitzke

Copy link
Copy Markdown
Contributor

Description

Moves team selection out of the UserWorkspaces singleton's mutable WindowId → team_uid map and makes it immutable window-owned state.

  • Introduces WindowTeam, initialized once per window.
  • Carries the same team identity through RootView, Workspace, restoration, inherited windows, detached tabs, and explicit team-switch windows.
  • Keeps UserWorkspaces responsible for resolving the selected UID to live team/workspace metadata.
  • Removes metadata-refresh reconciliation that could retarget an existing window.
  • Preserves lightweight test-only team overrides for fixtures that do not construct a full workspace window.

This is a direction-review draft related to the broader X-Warp-Team-Uid work in https://github.com/warpdotdev/warp-server/pull/14108. It does not yet attach the header to MAA requests.

Linked Issue

No linked issue yet; this draft is intended to review the client ownership model before expanding the transport/server work.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Not run for this direction-review draft, per request.

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

IsaiahWitzke and others added 4 commits August 18, 2026 14:41
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-agent on this PR to send it follow-up work.

View run View conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Your Warp account is not a member of any team with access to this repository.

Co-Authored-By: Warp <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant