[fix](VA) Keep non-zero wait action groups in computer-use recordings

[vkodithala]

Description

Computer-use recordings on Linux are smart-trimmed: only committed action groups produce keep-windows, and everything else is hard-cut. is_meaningful_action_group treated every Wait-only batch as non-meaningful, so a standalone "wait for the UI to settle" call was never committed and its settling period was cut from the video, even though it plays out in real time on screen.

This changes the predicate to count any non-zero Wait as meaningful (via the existing Action::is_no_op() helper), while Wait(0) no-op batches — emitted for screenshot/zoom/cursor-position-only calls — remain excluded so empty frames are still trimmed. Non-Wait actions are unaffected. The commit path already records the full wait duration in the group's [offset, finish_offset] span, so no other changes are needed.

Linked Issue

N/A — recording-quality fix from the CU video trim pipeline work.

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Updated the existing is_meaningful_action_group unit test: a 500 ms wait-only group now asserts meaningful, while the Wait(0) and empty-slice cases keep asserting non-meaningful.

Ran locally (macOS):

• cargo nextest run -p computer_use — 62 passed, 0 skipped
• ./script/format --check — clean
• cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings — clean
• cargo clippy -p warp --all-targets --tests -- -D warnings — clean
• cargo clippy -p warp_completer --all-targets --tests -- -D warnings — clean

Not manually tested with ./script/run: the trim only runs on Linux recordings, and the change is fully covered by the unit test on the pure predicate.

• I have manually tested my changes locally with ./script/run

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Conversation: https://staging.warp.dev/conversation/df74c6da-5f2a-4a0f-99a6-7b9e8b64cb1f
Run: https://oz.staging.warp.dev/runs/019fb41e-c9c2-778f-844e-afcf68f7bf0e

CHANGELOG-BUG-FIX: Computer-use video recordings now keep real (non-zero) wait periods at real time instead of trimming them out.

Co-Authored-By: Oz oz-agent@warp.dev

[warp-for-oss]

@vkodithala

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-for-oss]

Overview

This PR updates computer-use recording trim eligibility so non-zero Wait-only action groups are retained while Wait(0) no-op groups remain excluded. The predicate and unit test changes are consistent with that intent, and I did not find security issues in the changed code.

Concerns

• The change affects user-visible Linux recording output, but the PR does not include a screenshot or screen recording demonstrating a non-zero wait-only action being retained end to end. Please attach visual evidence from a Linux recording run, either locally or from a computer-use-capable environment, before merging.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz