Skip to content

Expose cloud conversation storage setting in TUI - #14533

Merged
harryalbert merged 3 commits into
masterfrom
factory/app-5065-tui-cloud-conversation-setting
Jul 30, 2026
Merged

Expose cloud conversation storage setting in TUI#14533
harryalbert merged 3 commits into
masterfrom
factory/app-5065-tui-cloud-conversation-setting

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Expose agents.cloud_conversation_storage_enabled on all settings surfaces so it is included in the TUI settings schema and generated defaults. Runtime behavior and storage keys are unchanged.

Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785420442437649

Linked Issue

APP-5065

Testing

  • Testing-exempt category: constant-or-flag-default. The change only expands a declarative setting surface; a new test would tautologically assert the annotation, so the requester explicitly waived new tests.
  • ./script/format --check
  • cargo clippy commands from ./script/presubmit (passed)
  • cargo nextest run -p warp -E 'test(/settings/)' (376 passed)
  • cargo run -p warp --example generate_default_settings -- --surface tui /tmp/app-5065-tui-default-settings.toml (confirmed cloud_conversation_storage_enabled = true)
  • cargo run -p warp --bin generate_settings_schema -- /tmp/app-5065-settings-schema.json (confirmed x-warp-surfaces: ["gui", "tui"])
  • Full ./script/presubmit was also attempted; formatting and clippy/build passed, while the unscoped suite hit environment-dependent existing failures (build-cache permission behavior and integration tests requiring unavailable runtime services).

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: Make cloud conversation storage configurable in TUI settings.

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 30, 2026
@warp-agent-staging
warp-agent-staging Bot requested a review from harryalbert July 30, 2026 15:20
Co-Authored-By: Oz <oz-agent@warp.dev>
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review July 30, 2026 15:41

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert
harryalbert enabled auto-merge (squash) July 30, 2026 17:30
@harryalbert
harryalbert merged commit f79df8d into master Jul 30, 2026
28 checks passed
@harryalbert
harryalbert deleted the factory/app-5065-tui-cloud-conversation-setting branch July 30, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants