- 
                Notifications
    
You must be signed in to change notification settings  - Fork 49
 
Basically support XDG Base Directory specification on Linux #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           I've tested this on my system, work as expect.  | 
    
e1d438e    to
    851201f      
    Compare
  
    | 
           Thanks! work without problems.  | 
    
          
 You're welcome, and thanks for your test result too ~  | 
    
8e1fdd1    to
    c5ad9d4      
    Compare
  
    c5ad9d4    to
    1ebd953      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this work.
Could you update your code to use $XDG_STATE_HOME (according to version 0.8 of basedir-spec) to store history/log/autoback/autosave instead of $XDG_CONFIG_HOME ?
Also for code clarity, I suggest you to rename ?localto ?cache and ?user to ?config (and to create ?state).
          
 Sure. But now I am too busy to work on this. I will make my way to update the code. Anyway, thanks for your review and suggestions ~  | 
    
          
 @louisroyer I finish this in commit 6fba9a6.  | 
    
| 
           Closed for upstream reviving (TypesettingTools#264).  | 
    
This PR will fix Issue Aegisub#226. Inspired by or adapted from aria2/aria2@8bc1d37 and Aegisub#148.
My basic idea just is:
$HOME/.aegisubexists, then the program will still read/write config/cache/data from there;$HOME/.aegisubdoesn't exist, then the program will read/write config/cache/data from corresponding XDG Base Directory.I think this idea may need more optimization, but I just pull a request first so we could discuss the detail.