Skip to content

Conversation

@faridyagubbayli
Copy link
Collaborator

@faridyagubbayli faridyagubbayli commented Apr 23, 2024

Closes #263

Splits the long make_line function into two new functions. The first function handles drawing straight lines while the second draws lines with angle.

  • Add "edge case" tests

@codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 64.22764% with 44 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (2e0bd5c) to head (8b5eee1).

Current head 8b5eee1 differs from pull request most recent head 34d5764

Please upload reports for the commit 34d5764 to get more accurate results.

Files Patch % Lines
kwave/utils/mapgen.py 64.22% 32 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   71.59%   71.80%   +0.21%     
==========================================
  Files          46       46              
  Lines        6738     6697      -41     
  Branches     1496     1487       -9     
==========================================
- Hits         4824     4809      -15     
+ Misses       1345     1321      -24     
+ Partials      569      567       -2     
Flag Coverage Δ
3.10 72.01% <64.22%> (+0.21%) ⬆️
3.11 72.01% <64.22%> (+0.21%) ⬆️
3.12 72.01% <64.22%> (+0.21%) ⬆️
3.9 71.78% <64.22%> (+0.21%) ⬆️
macos-latest 71.74% <64.22%> (+0.21%) ⬆️
ubuntu-latest 71.77% <64.22%> (+0.21%) ⬆️
windows-latest 71.79% <64.22%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waltsims
Copy link
Owner

@copilot add edge cases tests

Copy link

Copilot AI commented Nov 12, 2025

@waltsims I've opened a new pull request, #648, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor make_line in kwave.utils.mapgen

4 participants