Proposal: SecurityInfo in WebRequest
#899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Nov 6, 2025
This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 7, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 10, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 10, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 11, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 14, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 14, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 18, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 18, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
Author
|
@Rob--W Hi, any comments on the proposal? |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 19, 2025
The change parses SecurityInfo object according to specification: w3c/webextensions#899 @devlin has given approval to start working on this feature before the spec is finalized. Fixed: 460072357 Change-Id: I160c4b61c0d2da46eab10fae4e0794c7f692d26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7167074 Commit-Queue: Vlad Krot <[email protected]> Reviewed-by: Dominic Battre <[email protected]> Cr-Commit-Position: refs/heads/main@{#1547169}
Member
I'm still in Japan following TPAC last week. I also have not had the chance to query for API usage (which I mentioned in https://github.com/w3c/webextensions/blob/main/_minutes/2025-11-06-wecg.md ), but that does not have to block my review. The most important part is to verify that similar names and properties have equivalent meanings across browsers. I am not available until mid December, but if this is really pressing I can ask another team member to assist in the verification (or do that myself when idle). On what timeframe do you need feedback? |
Author
|
@Rob--W It is fine for me to wait a week or two. |
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 19, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
AlexeyBarabash
pushed a commit
to brave/brave-core
that referenced
this pull request
Nov 19, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 20, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Nov 21, 2025
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal following discussion at #882