Upgrade Selenium atoms to revision 775cfb33b193eb8832cd5488f298006f45254685 #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ooo, @alexnj could you please take a look? |
jgraham
approved these changes
Oct 23, 2025
alexnj
approved these changes
Oct 23, 2025
|
@gsnedders can you please review as well? Thanks |
|
@gsnedders I assume this update is fine with you. I even don't know if Safari's implementation still uses the Selenium atoms. If there is a problem please let us know. Otherwise I'm going to merge this PR now because it fixes a regression. |
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Oct 28, 2025
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the Selenium atoms for
bot.dom.getVisibleText(). It finally got fixed and we should update our atoms to as well fix it in WebDriver classic clients.For the update in Firefox I'm working on https://bugzilla.mozilla.org/show_bug.cgi?id=1986392, and as well added a new test case for the wdspec tests.
Preview | Diff