Pass subtype to "create an input source"

[yezhizhen]

subtype is given in the context but never used.

---

Preview | Diff

[whimboo]

Good find!

There is one further thing that I noticed when checking the chain of calls: Within create an input source the subtype is mentioned as optional, while calling create a pointer input source requires the subtype. I think that we should remove the optional from the create an input source algorithm.

[yezhizhen]

I think we should still keep optional, as only "pointer input source" requires subtype.
There seems to be a bigger problem now: it seems most of caller don't passes subtype, even for those explicitly creating "pointer" input source, e.g. this.
cc @xiaochengh

I propose to add subtype to all callers that explicitly create "pointer", but keep subtype as optional in create an input source.

[OrKoN]

I think it's also related to this issue #1925 (comment)

[whimboo]

@yezhizhen good point! I completely missed that. So yes, that makes sense and great that you are going to fix the other freshly detected issues as well.

[whimboo]

So create an input source is called in step 6 of process an input source action sequence. There is no subtype passed in at the moment if it's a pointer input source. In its step 5 the parameters are processed and the subtype is available as parameters.pointerType. That one needs to be passed down.

[whimboo]

Suggested change

	sequence</var>, and <var>actions options</var>, and optional <var>subtype</var>,
	sequence</var>, <var>actions options</var>, and optional <var>subtype</var>,

[whimboo]

At this level subtype is undefined. It's not part of the outer actions dictionary but part of inner actions (specifically pointer as you pointed out). So we cannot pass subtype here. Here an example:

{
  "actions": [
    {
      "type": "pointer",
      "actions": [
        {
          "type": "pointerMove",
          "x": 49,
          "y": 49,
          "origin": {
            "element-6066-11e4-a52e-4f735466cecf": "32a6492e-a085-405e-a39a-9765c35dcb2e"
          }
        },
        {
          "type": "pointerDown",
          "button": 0
        },
        {
          "type": "pointerMove",
          "x": 149,
          "y": 149,
          "origin": {
            "element-6066-11e4-a52e-4f735466cecf": "32a6492e-a085-405e-a39a-9765c35dcb2e"
          }
        },
        {
          "type": "pointerUp",
          "button": 0
        }
      ],
      "parameters": {
        "pointerType": "mouse"
      },
      "id": "1"
    }
  ]
}

[whimboo]

Note that here we still have a list of )(inner) actions that are getting passed to process an input source action sequence. So we still don't have a type subtype and as such won't need the variable.

[whimboo]

So create an input source is called in step 6 of process an input source action sequence. There is no subtype passed in at the moment if it's a pointer input source. In its step 5 the parameters are processed and the subtype is available as parameters.pointerType. That one needs to be passed down.