Skip to content

Conversation

@HodanPlodky
Copy link
Collaborator

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->


from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.function import IRFunction
from vyper.venom.memory_allocator import MemoryAllocator

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'MemoryAllocator' may not be defined if module
vyper.venom.memory_allocator
is imported before module
vyper.venom.context
, as the
definition
of MemoryAllocator occurs after the cyclic
import
of vyper.venom.context.
'MemoryAllocator' may not be defined if module
vyper.venom.memory_allocator
is imported before module
vyper.venom.context
, as the
definition
of MemoryAllocator occurs after the cyclic import of vyper.venom.context.

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.basicblock import IRAbstractMemLoc, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRVariable' may not be defined if module
vyper.venom.basicblock
is imported before module
vyper.venom.function
, as the
definition
of IRVariable occurs after the cyclic
import
of vyper.venom.function.
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 89.38356% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.05%. Comparing base (db8abe8) to head (15bf144).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/check_venom.py 77.27% 27 Missing and 13 partials ⚠️
vyper/venom/memory_location.py 87.00% 19 Missing and 4 partials ⚠️
vyper/venom/passes/mem2var.py 87.80% 5 Missing and 5 partials ⚠️
vyper/venom/passes/concretize_mem_loc.py 95.93% 4 Missing and 4 partials ⚠️
vyper/venom/passes/load_elimination.py 86.95% 2 Missing and 1 partial ⚠️
vyper/venom/venom_to_assembly.py 25.00% 3 Missing ⚠️
vyper/venom/function.py 60.00% 2 Missing ⚠️
vyper/venom/memory_allocator.py 92.85% 1 Missing and 1 partial ⚠️
vyper/venom/parser.py 85.71% 0 Missing and 1 partial ⚠️
vyper/venom/passes/simplify_cfg.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4756      +/-   ##
==========================================
- Coverage   93.23%   93.05%   -0.19%     
==========================================
  Files         137      140       +3     
  Lines       19452    20198     +746     
  Branches     3354     3526     +172     
==========================================
+ Hits        18136    18795     +659     
- Misses        893      951      +58     
- Partials      423      452      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,36 @@
from typing import Any

from vyper.venom.basicblock import IRAbstractMemLoc, IRLiteral

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRAbstractMemLoc' may not be defined if module
vyper.venom.basicblock
is imported before module
vyper.venom.memory_allocator
, as the
definition
of IRAbstractMemLoc occurs after the cyclic
import
of vyper.venom.memory_allocator.
@@ -0,0 +1,36 @@
from typing import Any

from vyper.venom.basicblock import IRAbstractMemLoc, IRLiteral

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRLiteral' may not be defined if module
vyper.venom.basicblock
is imported before module
vyper.venom.memory_allocator
, as the
definition
of IRLiteral occurs after the cyclic
import
of vyper.venom.memory_allocator.
_offset = offset.value
return MemoryLocationConcrete(_offset, _size)
elif isinstance(offset, IRVariable):
_offset = None

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _offset is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant