Skip to content

Conversation

@jestabro
Copy link
Contributor

@jestabro jestabro commented Nov 10, 2025

Change summary

NOTE: this PR will be updated with revised commit hashes, following the merge of
vyos/vyos1x-config#56
vyos/vyconf#35

In addition, it adjusts some internal function names to distinguish between the existing compare command (which is already vyconf aware) and the show command.
Given the function name changes, package integration will fail until the above PRs are merged and commit refs updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal update

Related Task(s)

Related PR(s)

vyos/vyos1x-config#56
vyos/vyconf#35

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

👍
No issues in PR Title / Commit Title

@github-actions
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests VPP ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • Config tests VPP ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace show diff with diff_compare

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants