Add support for nested CSS variables#90
Open
andrewda wants to merge 5 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: b915fe7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Yeom-JinHo
reviewed
Oct 23, 2024
| }; | ||
|
|
||
| public resolveRecursiveVariables = (value: string) => { | ||
| for (let i = 0; i < 20; i++) { |
There was a problem hiding this comment.
Why does the for loop run 20? Is it because the maximum recursion depth is thought to be 20?
Comment on lines
+78
to
+88
| const variableReference = value.match(/^var\(\s*([a-zA-Z0-9-]+)\s*\)$/)?.[1]; | ||
| if (variableReference) { | ||
| const newValue = this.cacheManager.get(variableReference)?.symbol?.value; | ||
| if (newValue) { | ||
| value = newValue; | ||
| } else { | ||
| break; | ||
| } | ||
| } else { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const variableReference = value.match(/^var\(\s*([a-zA-Z0-9-]+)\s*\)$/)?.[1]; | |
| if (variableReference) { | |
| const newValue = this.cacheManager.get(variableReference)?.symbol?.value; | |
| if (newValue) { | |
| value = newValue; | |
| } else { | |
| break; | |
| } | |
| } else { | |
| break; | |
| } | |
| const variableReference = value.match(/^var\(\s*([a-zA-Z0-9-]+)\s*\)$/)?.[1]; | |
| if (!variableReference) { | |
| break; | |
| } | |
| const newValue = this.cacheManager.get(variableReference)?.symbol?.value; | |
| if (newValue) { | |
| value = newValue; | |
| continue; | |
| } | |
| break; |
I think nested if statements are complicated. How about this?
FourwingsY
reviewed
Oct 28, 2024
| "dependencies": { | ||
| "axios": "^0.27.2", | ||
| "culori": "0.20.1", | ||
| "culori": "^4.0.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for nested CSS variables. See screenshot for example:
Resolves #14