feat: update OpenSOME/IP from v0.0.5 to v0.1.0 - #18
Merged
Conversation
Bump opensomeip dependency to v0.1.0 which brings spec-compliance fixes for SD wire formats, shared library packaging, and MISRA-aligned static analysis. No source changes required — body-ecu's API usage is already compatible with the new explicit constructors and type widenings. Fixes #17 Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThe PR upgrades OpenSOME/IP from v0.0.5 to v0.1.0 across three manifest and configuration files. CMake adds a ChangesOpenSOME/IP v0.1.0 Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
opensomeip v0.1.0 uses add_library() without STATIC/SHARED, so it follows BUILD_SHARED_LIBS. Fedora's %cmake macro sets this to ON, causing unresolved symbol errors at link time. Save and restore the variable around the opensomeip include to always build it statically. Co-authored-by: Cursor <cursoragent@cursor.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmake/opensomeip.cmake`:
- Around line 22-23: The current save/restore of BUILD_SHARED_LIBS using
_SAVED_BUILD_SHARED_LIBS will restore an empty string if BUILD_SHARED_LIBS was
originally undefined; change the pattern to record whether BUILD_SHARED_LIBS was
defined (e.g., save a flag like _SAVED_BUILD_SHARED_LIBS_DEFINED in addition to
_SAVED_BUILD_SHARED_LIBS) when you set _SAVED_BUILD_SHARED_LIBS, and on restore
check that flag: if it was defined, set BUILD_SHARED_LIBS back to the saved
value, otherwise unset BUILD_SHARED_LIBS so it remains undefined; update the
code that references _SAVED_BUILD_SHARED_LIBS and BUILD_SHARED_LIBS accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5a9509fc-a3f5-4bba-8a26-0255bb82ca06
📒 Files selected for processing (3)
.specs/prd.mdcmake/opensomeip.cmakewest.yml
Use DEFINED check to distinguish between unset and empty-string when restoring BUILD_SHARED_LIBS after opensomeip inclusion. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
west.yml,cmake/opensomeip.cmake, and.specs/prd.mdSomeIpSystem) is already compatible with all breaking changes (explicit constructors, type widenings, deleted copy/move)Test plan
tests/integration/test_two_process.py)Fixes #17
Made with Cursor
Summary by CodeRabbit
Release Notes