Inherit controller push settings

[max-potapov]

this will fix the issue with tabbar controller show on table cell selection

[adam-pecev-wrike]

@vtourraine What was the reason for closing this? Is there a recommended way how to do this? I.e. have the bottom bar hidden when having AcknowViewController pushed?

[vtourraine]

Hello Adam, and thanks for the message. I usually post a comment before closing a PR, but I guess I missed this one. My apologies!

Back then, I probably denied this change because I want to keep this library as simple as possible, by sticking to the default UIKit/SwiftUI behaviors (and let developers fork the repo if they really need something custom).

8 years later, it looks like the situation hasn’t changed, so I think I’ll make an exception and merge this in. I agree that the tab bar behavior should be transferred to details view.

[adam-pecev-wrike]

8 years later, it looks like the situation hasn’t changed, so I think I’ll make an exception and merge this in. I agree that the tab bar behavior should be transferred to details view.

Cool, thank you! 🤩 You don't need to make it default if you think it could be a breaking change. Exposure of a new property/function/init (whatever suits this library better) through which we could set it up would be enough.

[max-potapov]

Rebased this onto the current main and resolved the conflict — the branch was 8 years / 258 commits behind, and Source/AcknowListViewController.swift had since moved to Sources/AcknowList/, so it came through as a modify/delete conflict.

While resolving I also applied the change to the second push site that was added in the meantime (the GitHub-license fetch path), so the tab-bar behavior is now inherited consistently in both branches of didSelectRowAt.

Re: @adam-pecev-wrike's note about not making it default — this isn't a breaking change. It just forwards the list controller's standard hidesBottomBarWhenPushed to the pushed detail controller, and that property defaults to false, so existing behavior is preserved unless a developer opts in via the existing UIKit property. No new public API needed.

swift build passes and the PR now shows as mergeable. 🙂

[vtourraine]

Fantastic, thank you both 🙌

I’ll push an update next week. Happy coding!