Skip to content

UIApplication avoidance #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KieranHarper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UIApplication avoidance #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Source/AcknowListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ open class AcknowListViewController: UITableViewController {
It expects to get set by "User Defined Runtime Attributes" in Interface Builder.
*/
@IBInspectable var acknowledgementsPlistName: String?

/// Closure that can open URLs, so that this doesn't have to use UIApplication
public var urlOpener: ((URL) -> Void)?


// MARK: - Initialization
Expand Down Expand Up @@ -240,13 +243,8 @@ open class AcknowListViewController: UITableViewController {
- parameter sender: The event sender.
*/
@IBAction open func openCocoaPodsWebsite(_ sender: AnyObject) {
let url = URL(string: AcknowLocalization.CocoaPodsURLString())
if let url = url {
if #available(iOS 10.0, tvOS 10.0, *) {
UIApplication.shared.open(url, options: [:], completionHandler: nil)
} else {
UIApplication.shared.openURL(url)
}
if let url = URL(string: AcknowLocalization.CocoaPodsURLString()) {
urlOpener?(url)
}
}

Expand Down