Skip to content

Modification of attribute banner to fix issue with launching with qtconsole command #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hansonap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modification of attribute banner to fix issue with launching with qtconsole command #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a74c31
_banner = None causes issue when running with qtconsole command. See
hansonap Jan 11, 2019
6178a40
Removed un-necessary code.
hansonap Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions powershell_kernel/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from subprocess import check_output

from ipykernel.kernelbase import Kernel

from os import unlink, environ
Expand All @@ -8,13 +10,16 @@
import signal
import urllib

from traitlets import default, Unicode

from powershell_kernel import subprocess_repl, powershell_proxy
from powershell_kernel.util import get_powershell

__version__ = '0.0.7'

version_pat = re.compile(r'version (\d+(\.\d+)+)')


class PowerShellKernel(Kernel):
implementation = 'powershell_kernel'
implementation_version = __version__
Expand All @@ -24,11 +29,12 @@ def language_version(self):
m = version_pat.search(self.banner)
return m.group(1)

_banner = None
banner = Unicode()

@property
def banner(self):
return self._banner
@default('banner')
def _banner_default(self):
return check_output(['powershell', '$PSVersionTable.PSVersion']).decode('utf-8')
# return self._banner

language_info = {'name': 'powershell',
'codemirror_mode': 'shell',
Expand All @@ -37,7 +43,7 @@ def banner(self):

def __init__(self, **kwargs):
Kernel.__init__(self, **kwargs)

# powershell_command env variable is set by the kernel to allow both powershell and pwsh
# but on python2 we cannot pass it thru env variable, see https://github.com/vors/jupyter-powershell/issues/7
# TODO(python2): can we pass it somehow differently and still provide user-picked value on python2?
Expand All @@ -54,7 +60,7 @@ def do_execute(self, code, silent, store_history=True,
if not code.strip():
return {'status': 'ok', 'execution_count': self.execution_count,
'payload': [], 'user_expressions': {}}

self.proxy.send_input(code)
output = self.proxy.get_output()

Expand Down