Creates all dialogs inside jtable-main-container #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this work with multiple jtables on same page. I don't mean parent child. At the moment with the dialogs attached to the main window they are shared by the code from all tables. |
Contributor
Author
|
Each table will create its own set of dialogs, the same way as it is now. The only difference is the location of the dialog on the DOM. I've proposed this change because I'm working with polymer web-components. I wrapped a jtable inside a web-component and in this case I need to have everything encapsulated inside the web-component host. This way you can have different dialog configuration for each table, and all code is removed from the DOM when jtable main container is removed. |
|
Sounds great. Why is this not happening? |
Logof
pushed a commit
to Logof/jTable
that referenced
this pull request
Jul 23, 2022
Logof
added a commit
to Logof/jTable
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715