Conversation
Duncaen
requested changes
Sep 25, 2026
| conf_files="/etc/biboumi/biboumi.cfg" | ||
| make_dirs="/var/lib/biboumi/ 0755 _biboumi _biboumi" | ||
| make_dirs="/var/lib/biboumi/ 0750 _biboumi _biboumi | ||
| /etc/biboumi 0750 _biboumi _biboumi" |
Member
There was a problem hiding this comment.
Config files generally shouldn't be writable by less privileged daemons imho.
Contributor
Author
|
This is the containing directory, not the file itself. The file is only
writable by root.
|
Member
Its still has perms to drop in config files. Owner should probably be root, group should be read only for the less privileged group. |
Adjust the permissions and ownership of the configuration directory to prevent the contents from being world readable as the configuration file stored within by default contains the component secret and remove the world read bit from the home directory as that's where the database is being looked for by default.
balejk
force-pushed
the
biboumi-tightening
branch
from
September 25, 2026 18:03
69ab0b3 to
ddf83ab
Compare
Contributor
Author
|
Fixed, thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the permissions and ownership of the configuration directory to
prevent the contents from being world readable as the configuration file
stored within by default contains the component secret and remove the
world read bit from the home directory as that's where the database is
being looked for by default.
Cc: @AnInternetTroll
Testing the changes
Local build testing