Skip to content

Conversation

@dkwo
Copy link
Contributor

@dkwo dkwo commented Dec 29, 2025

Built and tested on aarch64-glibc.

@dkwo dkwo marked this pull request as draft December 29, 2025 08:24
@tornaria
Copy link
Contributor

Thanks, I'll have a look later.

@dkwo
Copy link
Contributor Author

dkwo commented Jan 1, 2026

@tornaria I was not aware of the debates going on within sage, which led to dropping sagemath-standard among other things. (see e.g. sagemath/sage#41336 (comment) ). If you prefer to do things differenlty in Void, just let me know and I will close this PR.

@dkwo dkwo force-pushed the sage108 branch 3 times, most recently from 361c28e to 14f8dba Compare January 6, 2026 01:53
@dkwo dkwo force-pushed the sage108 branch 2 times, most recently from 2199dcc to c723f2f Compare January 13, 2026 02:23
@dkwo dkwo marked this pull request as ready for review January 13, 2026 02:26
@dkwo dkwo force-pushed the sage108 branch 3 times, most recently from 142bb66 to 8403bc9 Compare January 15, 2026 04:01
@dkwo
Copy link
Contributor Author

dkwo commented Jan 15, 2026

@tornaria @ahesford This is now ready for review.

tornaria added a commit to tornaria/void-packages that referenced this pull request Jan 24, 2026
@ahesford ahesford marked this pull request as draft January 27, 2026 14:20
@ahesford
Copy link
Member

This should remain as a draft until the Cython change is merged upstream.

@tornaria
Copy link
Contributor

This should remain as a draft until the Cython change is merged upstream.

@dkwo, why is patching cython necessary? What breaks without it? Can we workaround it without patching cython?

@dkwo
Copy link
Contributor Author

dkwo commented Jan 27, 2026

I was getting two test failures in sage/misc/sageinspect.py and I was informed in sagemath/sage#39872 (comment) that they are fixed in cython/cython#6755

Maybe we can go ahead without the cython patch for now?

@dkwo
Copy link
Contributor Author

dkwo commented Feb 2, 2026

@ahesford @tornaria The cython pull request has been merged cython/cython#6755

@tornaria
Copy link
Contributor

tornaria commented Feb 5, 2026

@ahesford @tornaria The cython pull request has been merged cython/cython#6755

Indeed, @ahesford what do you think? I can update #58668 either way, is not a big deal (I can workaround the test failures for the time being).

It would be nice to move forward with #58668 soon so I'd rather skip the cython patch than stall the PR.

tornaria added a commit to tornaria/void-packages that referenced this pull request Feb 6, 2026
@ahesford
Copy link
Member

ahesford commented Feb 6, 2026

cython/cython#6755 (comment) doesn't inspire a lot of confidence. If that change is only about fixing some tests, I'd rather not pull the patch; let's work around the test failure until the change makes it into a proper Cython release. If that change fixes some important functionality in Sage, we can pull the patch and take our chances.

@tornaria
Copy link
Contributor

tornaria commented Feb 6, 2026

cython/cython#6755 (comment) doesn't inspire a lot of confidence. If that change is only about fixing some tests, I'd rather not pull the patch; let's work around the test failure until the change makes it into a proper Cython release. If that change fixes some important functionality in Sage, we can pull the patch and take our chances.

I'll push a workaround then. As a matter of fact, we weren't using --embed-positions in our build of 10.7 so I think we can just disable that for the time being.

tornaria added a commit to tornaria/void-packages that referenced this pull request Feb 7, 2026
@dkwo
Copy link
Contributor Author

dkwo commented Feb 9, 2026

Let us continue discussion in #58668 ,which includes this pr.

@dkwo dkwo closed this Feb 9, 2026
@dkwo
Copy link
Contributor Author

dkwo commented Feb 9, 2026

Let us continue discussion in #58668 ,which includes this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants