New package: Criterion-2.4.3

[MIvanchev]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64-GLIBC)

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[Duncaen]

This fails to build when rebased.

[Rutpiv]

The build issue was caused by the recent update to CMake 4, which removed compatibility with CMakeLists.txt files targeting versions older than 3.5 — as was the case with the version of nanopb used in the original wrap.

To fix this, I updated the nanopb subproject to version 0.4.9.1 (previously 0.4.7), along with its corresponding checksum. This version is compatible with CMake 4. With this change, the build completes successfully, and all tests pass as expected.

---

Additionally, I attempted to update nanomsg to version 1.2.1, although the Meson wrap requires only version 1.2. While version 1.2 builds and works correctly, version 1.2.1 causes several tests in Criterion to fail with SIGABRT.

Tests errors

=> Criterion-2.4.2_1: running do_check ...
ninja: Entering directory `/builddir/Criterion-2.4.2/Criterion-2.4.2/build'
ninja: no work to do.
 1/19 boxfort / nested.c                        OK              0.02s
 2/19 boxfort / callback.c                      OK              0.02s
 3/19 boxfort / context.c                       OK              0.03s
 4/19 criterion / unit tests                    ERROR           0.07s   killed by signal 6 SIGABRT
>>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=45 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/unit/unit_tests --tap

 5/19 criterion / full / exit.c                 FAIL            0.08s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=89 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/exit.c.bin --always-succeed

 6/19 criterion / full / failmessages.c         FAIL            0.09s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 MALLOC_PERTURB_=116 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/failmessages.c.bin --always-succeed

 7/19 criterion / full / flood.c                OK              0.04s
 8/19 criterion / full / long-messages.c        FAIL            0.05s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=107 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/long-messages.c.bin --always-succeed

 9/19 criterion / full / other-crashes.c        FAIL            0.05s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 MALLOC_PERTURB_=227 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/other-crashes.c.bin --always-succeed

10/19 criterion / full / with-time.c            FAIL            0.05s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=237 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/with-time.c.bin --always-succeed

11/19 criterion / full / bug463.c               FAIL            0.05s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=150 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/bug463.c.bin --always-succeed

12/19 criterion / full / theories_regression.c  OK              0.06s
13/19 criterion / full / exception.cc           FAIL            0.09s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=119 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/exception.cc.bin --always-succeed

14/19 criterion / full / exit.cc                FAIL            0.09s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 MALLOC_PERTURB_=114 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/exit.cc.bin --always-succeed

15/19 criterion / full / failmessages.cc        FAIL            0.09s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 MALLOC_PERTURB_=241 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/failmessages.cc.bin --always-succeed

16/19 criterion / full / long-messages.cc       FAIL            0.06s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=100 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/long-messages.cc.bin --always-succeed

17/19 criterion / full / other-crashes.cc       FAIL            0.05s   killed by signal 6 SIGABRT
>>> LD_LIBRARY_PATH=/builddir/Criterion-2.4.2/Criterion-2.4.2/build/src ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=127 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 /builddir/Criterion-2.4.2/Criterion-2.4.2/build/test/full/other-crashes.cc.bin --always-succeed

18/19 criterion / full / theories_regression.cc OK              0.06s
19/19 boxfort / timeout.c                       OK              2.01s

Ok:                 7   
Expected Fail:      0   
Fail:               12  
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

These errors do not occur with `nanomsg versions 1.1.5 or 1.2, which both build and pass the test suite successfully.

[MIvanchev]

Where did you update nanopb @Rutpiv ? In the CMake files? I'll patch right up, your findings are identical to mine 👍 thank you.

[Rutpiv]

I updated nanopb directly inside the Criterion template you provided, as the patch structure suggests it sources the files directly from there. Glad to hear our findings align — let me know if there’s anything else I can help with.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[Rutpiv]

Bump.

[MIvanchev]

@Rutpiv I forgot to answer you, I'll test this asap and commit, thank you, sorry!!!

[Rutpiv]

No worries, take your time. Thanks for letting me know!

[Rutpiv]

Criterion has released version 2.4.3, which now depends on nanomsg 1.2.2 in its Meson wrap.
I have opened a PR updating nanomsg to 1.2.2 to match this new requirement: #57875.

[MIvanchev]

Thanks for all your effort @Rutpiv, maybe we'll get this released!

[Rutpiv]

Thanks for the kind words, and thank you as well for driving this forward.
Really looking forward to seeing this land in the repository.